GneissWeb_recipe_notebook #1055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
This was referenced Feb 18, 2025
Signed-off-by: SHAHROKH DAIJAVAD <[email protected]>
shahrokhDaijavad
approved these changes
Feb 18, 2025
There was a problem hiding this comment.
@Hajar-Emami I approve this, knowing that multiple optmizations are needed in a subsequent version of this notebook, based on a few transform PRs that have not been merged yet.
|
@Hajar-Emami You need to delete the files you have added to the extreme-tokenized transform directory (a test notebook and the test_output directory), before we can merge. Thanks. |
|
Thanks @shahrokhDaijavad I’ve removed the files. |
shahrokhDaijavad
requested changes
Feb 18, 2025
Signed-off-by: SHAHROKH DAIJAVAD <[email protected]>
… what is in the dev branch Signed-off-by: SHAHROKH DAIJAVAD <[email protected]>
shahrokhDaijavad
approved these changes
Feb 19, 2025
|
@shivdeep-singh-ibm Please merge this PR, given my comment above that it needs further optimizations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
GneissWeb_recipe_notebook
Related issue number (if any).