Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fail to build transform spark image when using a release tag x.y.z (without any .devN suffix) #625

Open
1 of 2 tasks
touma-I opened this issue Sep 25, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@touma-I
Copy link
Collaborator

touma-I commented Sep 25, 2024

Search before asking

  • I searched the issues and found no similar issues.

Component

Makefiles

What happened + What you expected to happen

When building release 0.2.1, the spark transform was failing. On close inspection, I found that the make file correctly builds data-prep-kit-spark-3.5.2:latest but when building the image for the transform, the makefile was referencing data-prep-kit-spark-3-5-2:0.2.1 (using the 0.2.1 tag instead of the latest tag)

The log shows the following when building the image for the base image:

docker build -t data-prep-kit-spark-3.5.2:latest 	\
	--platform linux/amd64  			\
	--build-arg EXTRA_INDEX_URL=	\
	--build-arg BASE_IMAGE=  		\
	--build-arg BUILD_DATE=2024-09-25T14:15:22Z  	\
	--build-arg GIT_COMMIT=fafecea . 

The log shows for following when building the image for the transforms.

docker build -t noop-spark:0.2.1 	\
	--platform linux/amd64  			\
	--build-arg EXTRA_INDEX_URL=	\
	--build-arg BASE_IMAGE=data-prep-kit-spark-3.5.2:0.2.1  		\
	--build-arg BUILD_DATE=2024-09-25T14:37:58Z  	\
	--build-arg GIT_COMMIT=fafecea . 

The complete log can be found here: https://github.com/IBM/data-prep-kit/actions/runs/11034666653/job/30648903714?pr=622

Reproduction script

modify .make.versions and set DPK_VERSION_SUFFIX=
rebuild spark image and noop-transform image

Anything else

No response

OS

Ubuntu

Python

3.10.x, 3.11.x

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!
@touma-I touma-I added the bug Something isn't working label Sep 25, 2024
@touma-I touma-I changed the title [Bug] Fail to build transform spark image when using a release tag x.y.z (.dev) [Bug] Fail to build transform spark image when using a release tag x.y.z (without any .devN suffix) Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants