fix(file-uploader): fixes multiple tabbable elements bug and adds keyboard navigation to label #1422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm addressing the build failure. Will upload a fix for the fix soon. |
…hn/carbon-components into 1351-file-uploader-avt1-fix
asudoh
reviewed
Nov 9, 2018
| if (document.readyState === 'loading') { | ||
| document.addEventListener('DOMContentLoaded', () => { | ||
| const uploadLabel = document.getElementById('input-button'); | ||
| const uploadInput = document.getElementById('your-file-importer-id-here'); |
There was a problem hiding this comment.
Seems that the code here needs to be implemented in FileUploader vanilla class - Sent a private note.
|
bump @dakahn! |
|
Let me know if you want to finish this off or close it and work on it later 👍 |
|
I'm gonna close this up for now and revisit the work later. 🙇🏼♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1351