Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tab): re-enable elipsis #2180

Merged
merged 3 commits into from
Mar 22, 2019

Conversation

asudoh
Copy link
Contributor

@asudoh asudoh commented Mar 21, 2019

Fixes #2178.

Changelog

Removed

  • Code that had disabled tab's ellipsis somehow.

Testing / Reviewing

Testing can be done by the following:

  1. Click on "View full render" link in the tabs demo
  2. Type the following in Chrome DevTools' console: document.getElementById('tab-link-1').textContent = 'the long text the long text'

@netlify
Copy link

netlify bot commented Mar 21, 2019

Deploy preview for the-carbon-components ready!

Built with commit d81c77a

https://deploy-preview-2180--the-carbon-components.netlify.com

Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, tab titles are now overflowing with ellipses to indicate overflow content

Copy link
Contributor

@shixiedesign shixiedesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YES 🙌

Copy link
Contributor

@lovemecomputer lovemecomputer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@alisonjoseph alisonjoseph merged commit d14cc65 into carbon-design-system:master Mar 22, 2019
@carbon-bot
Copy link
Contributor

🎉 This PR is included in version 9.88.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants