-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tab): re-enable elipsis #2180
fix(tab): re-enable elipsis #2180
Conversation
Deploy preview for the-carbon-components ready! Built with commit d81c77a https://deploy-preview-2180--the-carbon-components.netlify.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, tab titles are now overflowing with ellipses to indicate overflow content
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
YES 🙌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
🎉 This PR is included in version 9.88.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Fixes #2178.
Changelog
Removed
Testing / Reviewing
Testing can be done by the following:
document.getElementById('tab-link-1').textContent = 'the long text the long text'