Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IE11: "Symbol is undefined" prevents modal from opening #2068

Closed
mattrosno opened this issue Mar 12, 2019 · 1 comment · Fixed by #2183
Closed

IE11: "Symbol is undefined" prevents modal from opening #2068

mattrosno opened this issue Mar 12, 2019 · 1 comment · Fixed by #2183
Labels
role: dev 🤖 type: bug 🐛

Comments

@mattrosno
Copy link
Member

Describe in detail the issue you're having.

Can't open modals in IE11 because of JS error. The specific error looks to be this JS:

if (typeof Symbol === "function)

Is this issue related to a specific component?

Modal

What did you expect to happen? What happened instead? What would you like to see changed?

Here's IE11:

image

What browser are you working in?

IE11

What version of the Carbon Design System are you using?

v10
asudoh added a commit to asudoh/carbon-components that referenced this issue Mar 22, 2019
@asudoh
fix(modal): fix JavaScript error in IE11
ca61c03 
We hit babel/babel#7597 with our logic turning `NodeList` to an array,
but turned out it's not needed there.

Fixes carbon-design-system#2068.
@asudoh asudoh mentioned this issue Mar 22, 2019
Merged
shixiedesign pushed a commit that referenced this issue Mar 22, 2019
@asudoh @shixiedesign
fix(modal): fix JavaScript error in IE11 (#2183)
148c5c8 
We hit babel/babel#7597 with our logic turning `NodeList` to an array,
but turned out it's not needed there.

Fixes #2068. 

Note: merging without reviewing on IE11 because designers are not set up with IE11. Will make an IE11 specific visual pass on all components & website after release.
@carbon-bot
Copy link
Contributor

🎉 This issue has been resolved in version 9.88.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
role: dev 🤖 type: bug 🐛
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(modal): fix JavaScript error in IE11 asudoh/carbon-components
4 participants
@asudoh @mattrosno @joshblack @carbon-bot