fix(text-input): position experimental password visibility toggle #1735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emyarod
added
version: 10
|
Deploy preview for the-carbon-components ready! Built with commit f3b0621 https://deploy-preview-1735--the-carbon-components.netlify.com |
|
@emyarod Could you fix the default options test case...? Thanks! |
emyarod
force-pushed
the
1734-broken-experimental-password-input
branch
from
802a167 to
adcb27c
Compare
|
yes it should be resolved now @asudoh |
emyarod
force-pushed
the
1734-broken-experimental-password-input
branch
from
adcb27c to
69987cc
Compare
|
Would other frameworks need to set the data attribute in order for styles to be applied? |
|
I refactored it to avoid selecting data attributes |
emyarod
force-pushed
the
1734-broken-experimental-password-input
branch
from
3e61f3d to
6b7071d
Compare
jnm2377
approved these changes
Feb 11, 2019
|
🎉 This PR is included in version 9.73.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1734
Related: #1058 #1060
This PR styles the password visibility toggle for the experimental text input. It also accounts for the new experimental error states and icon prefixes