Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix updateSettings and tests listing #2283

Merged
merged 2 commits into from
Feb 25, 2025
Merged

Fix updateSettings and tests listing #2283

merged 2 commits into from
Feb 25, 2025

Conversation

lampajr
Copy link
Member

@lampajr lampajr commented Feb 24, 2025 •
edited
Loading

Fixes Issue

Fixes #2281
Fixes #2282

Changes proposed

  • Convert watching from Set to Array
  • Ensure NotificatinServiceImpl create notification settings using persist rather than merge

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.

@lampajr lampajr merged commit d437b36 into Hyperfoil:master Feb 25, 2025
3 checks passed
@lampajr lampajr deleted the fix_issues branch February 25, 2025 07:35
@lampajr lampajr mentioned this pull request Feb 25, 2025
Merged
5 tasks
@lampajr lampajr self-assigned this Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lampajr lampajr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to list all tests in the UI Unable to add personal notification settings
1 participant
@lampajr