Fix label values limits #2272
Merged
Fix label values limits #2272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stalep
approved these changes
Feb 19, 2025
| @@ -531,6 +522,13 @@ protected static List<ExportedLabelValues> parse(List<Object[]> nodes) { | |||
| return exportedLabelValue; | |||
| }))); | |||
|
|
|||
| if (limit != null && limit > 0) { | |||
| page = (page == null || page < 0) ? 0 : page; | |||
| List<List<ExportedLabelValues>> partitioned = Lists.partition(exportedLabelValues.values().stream().toList(), | |||
There was a problem hiding this comment.
Can we use Collectors.partitioning/groupingBy instead of Guava Lists?
There was a problem hiding this comment.
Good suggestion, let me see if that works since it will avoid to add the new guava dependency only for this
There was a problem hiding this comment.
@stalep looks like I was able to get rid of guava as I don't actually need to partition the records.. I just need to skip the first limit * page elements and keep the other limit ones:
if (limit != null && limit > 0) {
long toSkip = (long) limit * ((page == null || page < 0) ? 0 : page);
return exportedLabelValues.values().stream().skip(toSkip).limit(limit).collect(Collectors.toList());
}wdyt?
Signed-off-by: Andrea Lamparelli <[email protected]>
lampajr
force-pushed
the
fix_label_values_limit
branch
from
89f9e6d to
edf9b9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue
Fixes #2266
Changes proposed
With #1977 we changed how the labelValues implementation was done, the main change was that we moved the run/datasset aggregation from db logic to Java for performance reasons.
Unfortunately this change introduced the regression described in #2266.
With this change I am proposing to move the
limitlogic to Java as well, given that it would be quite not possible to do that at db level given that the aggregation is not there anymore.Check List (Check all the applicable boxes)