Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type safety to sequence generators #1558

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

barreiro
Copy link
Collaborator

No description provided.

@stalep stalep added this to the 0.13 milestone Apr 2, 2024
@stalep
Copy link
Member

stalep commented Apr 2, 2024

looks good, but with this change I thing we also should delete io.hyperfoil.tools.horreum.entity.SeqIdGenerator ?

@johnaohara
Copy link
Member

looks good, but with this change I thing we also should delete io.hyperfoil.tools.horreum.entity.SeqIdGenerator ?

@stalep have we separated all the update/add logic from entities. I think this is needed if we still update/add entities with an em.merge?

@stalep
Copy link
Member

stalep commented Apr 15, 2024

looks good, but with this change I thing we also should delete io.hyperfoil.tools.horreum.entity.SeqIdGenerator ?

@stalep have we separated all the update/add logic from entities. I think this is needed if we still update/add entities with an em.merge?

Good point, we have not...

@johnaohara
Copy link
Member

I think we will cover removing io.hyperfoil.tools.horreum.entity.SeqIdGenerator in a seperate PR, as this would mean changes to the API and is more intrusive

@johnaohara johnaohara merged commit 8e10b81 into Hyperfoil:master Apr 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants