Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect when RLS has been a cause for error. #1147

Merged
merged 1 commit into from
Jan 27, 2024
Merged

Detect when RLS has been a cause for error. #1147

merged 1 commit into from
Jan 27, 2024

Conversation

whitingjr
Copy link
Collaborator

Fixed calling the wrong apis function when updating Run access.

Fixes Issue

fixes #406
fixes #1145

Changes proposed

  • Add catch block for unauthorized exception type.
  • Swich call to apis to execute the Run access update function.

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • All new and existing tests passed.

@whitingjr whitingjr requested a review from johnaohara January 23, 2024 16:55
@whitingjr whitingjr self-assigned this Jan 23, 2024
@johnaohara johnaohara added type/bug Something isn't working backport labels Jan 23, 2024
@whitingjr whitingjr force-pushed the add-RLS-meaningful-error-message-update-access branch from e123ee5 to 81f3359 Compare January 26, 2024 10:26
johnaohara
johnaohara approved these changes Jan 27, 2024
View reviewed changes
Copy link
Member

@johnaohara johnaohara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnaohara johnaohara merged commit 2bbdac4 into Hyperfoil:master Jan 27, 2024
2 checks passed
@johnaohara
Copy link
Member

Merged

Thanks for your contribution!

@johnaohara johnaohara mentioned this pull request Jan 27, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnaohara johnaohara johnaohara approved these changes

Assignees

@whitingjr whitingjr

Labels
area/UI backport type/bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@whitingjr @johnaohara