Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactoring module layout of project #30

Closed
johnaohara opened this issue May 20, 2020 · 7 comments
Closed

refactoring module layout of project #30

johnaohara opened this issue May 20, 2020 · 7 comments
Labels
type/enhancement An enhancement to an existing feature

Comments

@johnaohara
Copy link
Member

The Horreum project is currently configured as a Maven multi-module project, with a single module repo. Originally this POC was to contain a number of different modules that consumed data from Horreum (e.g. Hyperfoil reporting tool), but projects consuming data from Horreum are being developed in their own repos.

I think it makes sense to just have Horreum as a single module project. Wanted to discuss this so that it does not interfere with current dev branches pple might have

@willr3 @rvansa thoughts?

@johnaohara johnaohara added the type/enhancement An enhancement to an existing feature label May 20, 2020
@rvansa
Copy link
Member

rvansa commented May 20, 2020

Hyperfoil report is closely tied to Hyperfoil itself, so it makes sense to keep it separate from Horreum which is supposed to be generic.
But what about alerting? IMO it would make sense to have both storage (current Horreum) and alerting/regression under single UI. Then it'd be convenient to have 3 modules: storage and alerting backends and UI frontend, within single repository.

@rvansa
Copy link
Member

rvansa commented May 28, 2020

@johnaohara ping?

@johnaohara
Copy link
Member Author

@rvansa sorry, completely forgot about this. Should we separate out alerting into a separate module, or just build it into the existing backend/frontend? Do we envisage Horreum to be modular? I think creating a modular architecture would add another layer of complexity. I think that we either have alerting completely separate (which implies a seperate GUI), or we bake it into Horreum, leaving Horreum as a single module project with data storage and reporting in one GUI

@rvansa
Copy link
Member

rvansa commented Jun 24, 2020

'Modular' sounds really too generic, and I have no idea how should modular React apps look like. All I am saying is that two UIs would hurt UX in my view.
I don't have a problem with backend separation if someone thinks that it will make it less of a spaghetti project. I don't have a issue with serving the UI from one container and running the backend(s) in another. But I haven't invented microservices either, my current stance is rather neutral.

@rvansa
Copy link
Member

rvansa commented Jul 16, 2020

@johnaohara Any further comments? Will you make the decision or should we do a poll?

@johnaohara
Copy link
Member Author

@rvansa as discussed
"lets do this, single application containing storage, alerting and unified UI, the storage and alerting have different URL paths, and if we need to split later it should be possible"

@rvansa rvansa closed this as completed Jul 16, 2020
@rvansa
Copy link
Member

rvansa commented Jul 16, 2020

I've pushed the changes, along with the package & some properties rename.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement An enhancement to an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants