-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactoring module layout of project #30
Comments
Hyperfoil report is closely tied to Hyperfoil itself, so it makes sense to keep it separate from Horreum which is supposed to be generic. |
@johnaohara ping? |
@rvansa sorry, completely forgot about this. Should we separate out alerting into a separate module, or just build it into the existing backend/frontend? Do we envisage Horreum to be modular? I think creating a modular architecture would add another layer of complexity. I think that we either have alerting completely separate (which implies a seperate GUI), or we bake it into Horreum, leaving Horreum as a single module project with data storage and reporting in one GUI |
'Modular' sounds really too generic, and I have no idea how should modular React apps look like. All I am saying is that two UIs would hurt UX in my view. |
@johnaohara Any further comments? Will you make the decision or should we do a poll? |
@rvansa as discussed |
I've pushed the changes, along with the package & some properties rename. |
The Horreum project is currently configured as a Maven multi-module project, with a single module
repo
. Originally this POC was to contain a number of different modules that consumed data from Horreum (e.g. Hyperfoil reporting tool), but projects consuming data from Horreum are being developed in their own repos.I think it makes sense to just have Horreum as a single module project. Wanted to discuss this so that it does not interfere with current dev branches pple might have
@willr3 @rvansa thoughts?
The text was updated successfully, but these errors were encountered: