Unable to add personal notification settings

[lampajr]

Describe the bug

Unable to create personal notifications from user settings

To Reproduce

1. Open personal user settings

2. Try to create a new setting
3. Fail with "jakarta.persistence.OptimisticLockException: Row was updated or deleted by another transaction"

Version

What is the version of Horreum ?

If you are using a development branch; what is the commit id ?

0.17.x

And older versions.

[lampajr]

The problem is that the updateSettings is implemented to remove all the existing settings for that user and re-create them:

Horreum/horreum-backend/src/main/java/io/hyperfoil/tools/horreum/svc/NotificationServiceImpl.java

Lines 150 to 165 in 2ae7ba4

	public void updateSettings(String name, boolean team, NotificationSettings[] settings) {
	NotificationSettingsDAO.delete("name = ?1 AND isTeam = ?2", name, team);
	Arrays.stream(settings).map(NotificationSettingsMapper::to).forEach(ns -> {
	if (!plugins.containsKey(ns.method)) {
	try {
	tm.setRollbackOnly();
	} catch (SystemException e) {
	log.error("Cannot rollback", e);
	}
	throw ServiceException.badRequest("Invalid method " + ns.method);
	}
	ns.name = name;
	ns.isTeam = team;
	em.merge(ns);
	});
	}

Then, the logic uses merge which is wrong as the entity is removed a couple of lines before.