-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-1577 / Make processNewOrUpdatedSchema asynchronous #1579
Comments
Worth to note that with this (temporary) approach we should stick with an increased transaction timeout (~120s) otherwise the |
This approach should also include some update to the UI so that the user knows the change is being processed in the background. There are parts of UI (e.g. assigning a run's schema) that relied on this being a synchronous operation. |
Good point, since this is meant to be (hopefully) a temporary solution, do you think it would be enough to show a popup/warning/alert on schema save? |
Something in the banner display or any other inline popup might work. I would avoid any use of |
Short term fix for of #1577
Feature idea.
Since fixing #1577 in the proper way could require some additional refactoring, that could have other implication, as short-term goal we decided to make the
processNewOrUpdatedSchema
Horreum/horreum-backend/src/main/java/io/hyperfoil/tools/horreum/svc/RunServiceImpl.java
Lines 176 to 182 in 3849f04
asynchronous, such that the creation/update of a
Schema
would become quite immediate and therun_schemas
update (especially theFIND_RUNS_WITH_URI
query execution) is handled asynchronously.Describe the solution you'd like
Create a new channel to manage this new event type, on event receiving, trigger the
processNewOrUpdatedSchema
method.Additional information
n/a
The text was updated successfully, but these errors were encountered: