Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate custom light component and use glTF punctual lights extension instead #5237

Open
takahirox opened this issue Mar 11, 2022 · 0 comments
Labels
enhancement work that enhances an existing feature

Comments

@takahirox
Copy link
Contributor

Is your feature request related to a problem? Please describe.

We use our custom light component but glTF has punctual lights extension. I don't think we really need the custon component for lights.

Describe the solution you'd like

Deprecate the custom light component, encourage to use glTF punctual lights extension instead, and let Spoke support the extension.

Benefits

  • Less maintenance cost. We can reduce our own code for lighting and rely on imported Three.js and other modules supporting glTF punctual lights extension
  • Better authoring model workflow. Models will have better compatibility and users will no longer need to learn/use Hubs specific authoring tools for lights.

Additional context

  • The glTF lights extension doesn't support cast/receiveShadow property. We may still need custom component for them. (And we might be able to propose cast/receiveShadow extension to glTF community. I'm writing a draft.)
  • glTF blender IO add-on doesn't seem to convert the lights power from blender to glTF correctly. We should work with them for better conversion. Intensity units when exporting point lights  KhronosGroup/glTF-Blender-IO#564 Maybe we want to deprecate the custom component after the blender exporter handles it correctly.
@takahirox takahirox added the enhancement work that enhances an existing feature label Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement work that enhances an existing feature
Projects
None yet
Development

No branches or pull requests

1 participant