Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't seem to work on Iphone X #25

Open
Badhumvee opened this issue Jun 1, 2019 · 5 comments
Open

Doesn't seem to work on Iphone X #25

Badhumvee opened this issue Jun 1, 2019 · 5 comments

Comments

@Badhumvee
Copy link

HI, We implemented vh-check in our webapp and tried it on iphone 8 and iphone X. It seems to work on iphone8 Safari but on iphoneX the height doesnt seem to adjust. I am not very familiar with the js used here but the fact that we are seeing it work on iphone8 tells me that we have implemented it correctly on our side. Any ideas why iphoneX is behaving differently?

@Hiswe
Copy link
Owner

Hiswe commented Jun 5, 2019

@Badhumvee Unfortunately not.
Maybe it's linked with those caveats?

@Badhumvee
Copy link
Author

@Hiswe, thanks for your response. Have you noticed this problem on your end as well? It would help if others can confirm something similar.

@phaistonian
Copy link

Confirmed.
Not related to the caveats since it's evident on both Safari and Chrome.

@Badhumvee
Copy link
Author

Any updates to this issue with Safari? How do we account for the notch in IphoneX?

@ghost
Copy link

ghost commented Feb 19, 2020

It’s not working on iPhone 11 Pro or iPad Pro 11 inch either

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants