From 5c053a68a8aeb9b9ad444a3c1cd0f3b970d1a8f8 Mon Sep 17 00:00:00 2001 From: Marko Tadic Date: Fri, 16 Sep 2022 15:49:15 +0200 Subject: [PATCH 1/2] Fix build warnings with Xcode 14.0 --- Sources/Transition/HeroTransition+Animate.swift | 2 +- Sources/Transition/HeroTransition+Complete.swift | 2 +- Sources/Transition/HeroTransition+Start.swift | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Sources/Transition/HeroTransition+Animate.swift b/Sources/Transition/HeroTransition+Animate.swift index 87862129..820b6f39 100644 --- a/Sources/Transition/HeroTransition+Animate.swift +++ b/Sources/Transition/HeroTransition+Animate.swift @@ -24,7 +24,7 @@ import UIKit extension HeroTransition { - open func animate() { + public func animate() { guard state == .starting else { return } state = .animating diff --git a/Sources/Transition/HeroTransition+Complete.swift b/Sources/Transition/HeroTransition+Complete.swift index 80137904..d01f85c1 100644 --- a/Sources/Transition/HeroTransition+Complete.swift +++ b/Sources/Transition/HeroTransition+Complete.swift @@ -25,7 +25,7 @@ import UIKit extension HeroTransition { - open func complete(finished: Bool) { + public func complete(finished: Bool) { if state == .notified { forceFinishing = finished } diff --git a/Sources/Transition/HeroTransition+Start.swift b/Sources/Transition/HeroTransition+Start.swift index 3bcd666a..2eefed22 100644 --- a/Sources/Transition/HeroTransition+Start.swift +++ b/Sources/Transition/HeroTransition+Start.swift @@ -25,7 +25,7 @@ import UIKit extension HeroTransition { - open func start() { + public func start() { guard state == .notified else { return } state = .starting From fd2ba86d4fe6cc7e6df291bc793855e49e3d4c09 Mon Sep 17 00:00:00 2001 From: Marko Tadic Date: Mon, 3 Oct 2022 09:55:34 +0200 Subject: [PATCH 2/2] Fix lint warnings --- Sources/Transition/HeroTransition+Start.swift | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Sources/Transition/HeroTransition+Start.swift b/Sources/Transition/HeroTransition+Start.swift index 2eefed22..09fb3f47 100644 --- a/Sources/Transition/HeroTransition+Start.swift +++ b/Sources/Transition/HeroTransition+Start.swift @@ -163,11 +163,11 @@ extension HeroTransition { processors.forEach { $0.process(fromViews: context.fromViews, toViews: context.toViews) } - + animatingFromViews = context.fromViews.filter { (view: UIView) -> Bool in animators.contains { $0.canAnimate(view: view, appearing: false) } } - + animatingToViews = context.toViews.filter { (view: UIView) -> Bool in animators.contains { $0.canAnimate(view: view, appearing: true) } }