forked from microsoft/testfx
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fixed a bug in
ITestDataSource data deserialization (microsoft#864)
- Fixed a bug in `ITestDataSource` data deserialization when trying to deserialize a type outside of current assembly. This should fix the last item in microsoft#844. - Added extra tests cases for `ITestDataSource`, we're now testing almost all cases we can think of.
- Loading branch information
Showing
15 changed files
with
766 additions
and
53 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
189 changes: 189 additions & 0 deletions
189
test/E2ETests/DiscoveryAndExecutionTests/TestDataSourceTests.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,189 @@ | ||
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // Licensed under the MIT license. See LICENSE file in the project root for full license information. | ||
|
|
||
| namespace Microsoft.MSTestV2.Smoke.DiscoveryAndExecutionTests | ||
| { | ||
| using Microsoft.MSTestV2.CLIAutomation; | ||
| using Microsoft.VisualStudio.TestPlatform.MSTest.TestAdapter.ObjectModel; | ||
| using Microsoft.VisualStudio.TestTools.UnitTesting; | ||
|
|
||
| using System.IO; | ||
| using System.Linq; | ||
|
|
||
| [TestClass] | ||
| public class TestDataSourceTests : CLITestBase | ||
| { | ||
| private const string TestAssembly = "DataSourceTestProject.dll"; | ||
|
|
||
| [TestMethod] | ||
| public void ExecuteCsvTestDataSourceTests() | ||
| { | ||
| // Arrange | ||
| var assemblyPath = Path.IsPathRooted(TestAssembly) ? TestAssembly : this.GetAssetFullPath(TestAssembly); | ||
|
|
||
| // Act | ||
| var testCases = DiscoverTests(assemblyPath, "CsvTestMethod"); | ||
| var testResults = RunTests(assemblyPath, testCases); | ||
|
|
||
| // Assert | ||
| Assert.That.ContainsTestsPassed(testResults, | ||
| "CsvTestMethod (Data Row 0)", | ||
| "CsvTestMethod (Data Row 2)" | ||
| ); | ||
|
|
||
| Assert.That.ContainsTestsFailed(testResults, | ||
| "CsvTestMethod (Data Row 1)", | ||
| "CsvTestMethod (Data Row 3)" | ||
| ); | ||
| } | ||
|
|
||
| [TestMethod] | ||
| public void ExecuteDynamicDataTests() | ||
| { | ||
| // Arrange | ||
| var assemblyPath = Path.IsPathRooted(TestAssembly) ? TestAssembly : this.GetAssetFullPath(TestAssembly); | ||
|
|
||
| // Act | ||
| var testCases = DiscoverTests(assemblyPath, "DynamicDataTest"); | ||
| var testResults = RunTests(assemblyPath, testCases); | ||
|
|
||
| // Assert | ||
| Assert.That.ContainsTestsPassed(testResults, | ||
| "DynamicDataTest (John;Doe,DataSourceTestProject.ITestDataSourceTests.User)" | ||
| ); | ||
|
|
||
| Assert.That.FailedTestCount(testResults, 0); | ||
| } | ||
|
|
||
| [TestMethod] | ||
| public void ExecuteDataRowTests_Enums() | ||
| { | ||
| // Arrange | ||
| var assemblyPath = Path.IsPathRooted(TestAssembly) ? TestAssembly : this.GetAssetFullPath(TestAssembly); | ||
|
|
||
| // Act | ||
| var testCases = DiscoverTests(assemblyPath, "FullyQualifiedName~DataRowTests_Enums"); | ||
| var testResults = RunTests(assemblyPath, testCases); | ||
|
|
||
| // Assert | ||
| Assert.That.TestsPassed(testResults, | ||
| "DataRowEnums_SByte (Alfa)", | ||
| "DataRowEnums_SByte (Beta)", | ||
| "DataRowEnums_SByte (Gamma)", | ||
| "DataRowEnums_Byte (Alfa)", | ||
| "DataRowEnums_Byte (Beta)", | ||
| "DataRowEnums_Byte (Gamma)", | ||
| "DataRowEnums_Short (Alfa)", | ||
| "DataRowEnums_Short (Beta)", | ||
| "DataRowEnums_Short (Gamma)", | ||
| "DataRowEnums_UShort (Alfa)", | ||
| "DataRowEnums_UShort (Beta)", | ||
| "DataRowEnums_UShort (Gamma)", | ||
| "DataRowEnums_Int (Alfa)", | ||
| "DataRowEnums_Int (Beta)", | ||
| "DataRowEnums_Int (Gamma)", | ||
| "DataRowEnums_UInt (Alfa)", | ||
| "DataRowEnums_UInt (Beta)", | ||
| "DataRowEnums_UInt (Gamma)", | ||
| "DataRowEnum_Long (Alfa)", | ||
| "DataRowEnum_Long (Beta)", | ||
| "DataRowEnum_Long (Gamma)", | ||
| "DataRowEnum_ULong (Alfa)", | ||
| "DataRowEnum_ULong (Beta)", | ||
| "DataRowEnum_ULong (Gamma)", | ||
|
|
||
| "DataRowEnums_Nullable_SByte ()", | ||
| "DataRowEnums_Nullable_SByte (Alfa)", | ||
| "DataRowEnums_Nullable_SByte (Beta)", | ||
| "DataRowEnums_Nullable_SByte (Gamma)", | ||
| "DataRowEnums_Nullable_Byte ()", | ||
| "DataRowEnums_Nullable_Byte (Alfa)", | ||
| "DataRowEnums_Nullable_Byte (Beta)", | ||
| "DataRowEnums_Nullable_Byte (Gamma)", | ||
| "DataRowEnums_Nullable_Short ()", | ||
| "DataRowEnums_Nullable_Short (Alfa)", | ||
| "DataRowEnums_Nullable_Short (Beta)", | ||
| "DataRowEnums_Nullable_Short (Gamma)", | ||
| "DataRowEnums_Nullable_UShort ()", | ||
| "DataRowEnums_Nullable_UShort (Alfa)", | ||
| "DataRowEnums_Nullable_UShort (Beta)", | ||
| "DataRowEnums_Nullable_UShort (Gamma)", | ||
| "DataRowEnums_Nullable_Int ()", | ||
| "DataRowEnums_Nullable_Int (Alfa)", | ||
| "DataRowEnums_Nullable_Int (Beta)", | ||
| "DataRowEnums_Nullable_Int (Gamma)", | ||
| "DataRowEnums_Nullable_UInt ()", | ||
| "DataRowEnums_Nullable_UInt (Alfa)", | ||
| "DataRowEnums_Nullable_UInt (Beta)", | ||
| "DataRowEnums_Nullable_UInt (Gamma)", | ||
| "DataRowEnums_Nullable_Long ()", | ||
| "DataRowEnums_Nullable_Long (Alfa)", | ||
| "DataRowEnums_Nullable_Long (Beta)", | ||
| "DataRowEnums_Nullable_Long (Gamma)", | ||
| "DataRowEnums_Nullable_ULong ()", | ||
| "DataRowEnums_Nullable_ULong (Alfa)", | ||
| "DataRowEnums_Nullable_ULong (Beta)", | ||
| "DataRowEnums_Nullable_ULong (Gamma)", | ||
|
|
||
| "DataRowEnums_MixedTypes_Byte (Alfa,True,1)", | ||
| "DataRowEnums_MixedTypes_Byte (Beta,False,2)", | ||
| "DataRowEnums_MixedTypes_Byte (Gamma,True,3)" | ||
| ); | ||
|
|
||
| Assert.That.FailedTestCount(testResults, 0); | ||
| } | ||
|
|
||
| [TestMethod] | ||
| public void ExecuteDataRowTests_NonSerializablePaths() | ||
| { | ||
| // Arrange | ||
| var assemblyPath = Path.IsPathRooted(TestAssembly) ? TestAssembly : this.GetAssetFullPath(TestAssembly); | ||
|
|
||
| // Act | ||
| var testCases = DiscoverTests(assemblyPath, "FullyQualifiedName~DataRowTests_NonSerializablePaths"); | ||
| var testResults = RunTests(assemblyPath, testCases); | ||
|
|
||
| // Assert | ||
| Assert.That.TestsPassed(testResults, | ||
| "DataRowNonSerializable (System.String)", | ||
| "DataRowNonSerializable (System.Int32)", | ||
| "DataRowNonSerializable (DataSourceTestProject.ITestDataSourceTests.DataRowTests_Enums)"); | ||
| Assert.That.FailedTestCount(testResults, 0); | ||
| } | ||
|
|
||
| [TestMethod] | ||
| public void ExecuteRegular_DataRowTests() | ||
| { | ||
| // Arrange | ||
| var assemblyPath = Path.IsPathRooted(TestAssembly) ? TestAssembly : this.GetAssetFullPath(TestAssembly); | ||
|
|
||
| // Act | ||
| var testCases = DiscoverTests(assemblyPath, "FullyQualifiedName~Regular_DataRowTests"); | ||
| var testResults = RunTests(assemblyPath, testCases); | ||
|
|
||
| // Assert | ||
| Assert.That.TestsPassed(testResults, | ||
| "DataRow1 (10)", | ||
| "DataRow1 (20)", | ||
| "DataRow1 (30)", | ||
| "DataRow1 (40)", | ||
| "DataRow2 (10,String parameter,True,False)", | ||
| "DataRow2 (20,String parameter,True,False)", | ||
| "DataRow2 (30,String parameter,True,False)", | ||
| "DataRow2 (40,String parameter,True,False)", | ||
| "DataRowTestMethodFailsWithInvalidArguments ()", | ||
| "DataRowTestMethodFailsWithInvalidArguments (2)", | ||
| "DataRowTestMethodFailsWithInvalidArguments (2,DerivedRequiredArgument,DerivedOptionalArgument,DerivedExtraArgument)", | ||
| "DataRowTestDouble (10.01,20.01)", | ||
| "DataRowTestDouble (10.02,20.02)", | ||
| "DataRowTestMixed (1,10,10,10,10,10,10,10,10)", | ||
| "DataRowTestMixed (2,10,10,10,10,10,10,10,10)", | ||
| "DataRowTestMixed (3,10,10,10,10,10,10,10,10)", | ||
| "DataRowTestMixed (4,10,10,10,10,10,10,10,10)", | ||
| "NullValueInData ([email protected],abc123,)", | ||
| "NullValueInData ([email protected],abc123,/unit/test)"); | ||
|
|
||
| Assert.That.FailedTestCount(testResults, 0); | ||
| } | ||
| } | ||
| } |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.