Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace RandomCardSample in evaluation_omaha.cc #60

Closed
azriel1rf opened this issue Oct 22, 2021 · 1 comment · Fixed by #91
Closed

replace RandomCardSample in evaluation_omaha.cc #60

azriel1rf opened this issue Oct 22, 2021 · 1 comment · Fixed by #91
Assignees
@azriel1rf
Labels
c++

Comments

@azriel1rf
Copy link
Collaborator

Thanks to @HenryRLee 's help, RandomCardSample in benchmark.cc is replaced. (#59, #56)

That has been code duplication with evaluation_omaha.cc since before.
It will be better to write it in another file (existing or new file) and include it.
@azriel1rf azriel1rf added the c++ label Oct 22, 2021
@HenryRLee
Copy link
Owner

Yeah, it's a good idea.

@azriel1rf azriel1rf self-assigned this Apr 29, 2024
@azriel1rf azriel1rf linked a pull request Apr 29, 2024 that will close this issue
Move CardSampler to separate files and use it in evaluation tests #91
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@azriel1rf azriel1rf

Labels
c++
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move CardSampler to separate files and use it in evaluation tests HenryRLee/PokerHandEvaluator
2 participants
@HenryRLee @azriel1rf