Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error checking in ReleaseDateService's Get method #82

Closed
Henry-Sarabia opened this issue Sep 29, 2020 · 1 comment
Closed

Fix error checking in ReleaseDateService's Get method #82

Henry-Sarabia opened this issue Sep 29, 2020 · 1 comment
Assignees
@Henry-Sarabia
Labels
bug
Milestone
v2.0.0-alpha.1

Comments

@Henry-Sarabia
Copy link
Owner

igdb/releasedate_test.go

Lines 24 to 26 in 1a22d94

err = json.Unmarshal(f, &init)
var tests = []struct {

This error should be checked but it is not.

Check the error.
@Henry-Sarabia Henry-Sarabia added this to the v2.0.0 milestone Sep 29, 2020
@Henry-Sarabia Henry-Sarabia self-assigned this Sep 29, 2020
@Henry-Sarabia Henry-Sarabia mentioned this issue Sep 29, 2020
Merged
@Henry-Sarabia
Copy link
Owner Author

This issue extends to ReleaseDateService's Index and List methods as well.

@Henry-Sarabia Henry-Sarabia reopened this Sep 29, 2020
@Henry-Sarabia Henry-Sarabia mentioned this issue Sep 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Henry-Sarabia Henry-Sarabia

Labels
bug
Projects
None yet
Milestone
v2.0.0-alpha.1
Development

No branches or pull requests
1 participant
@Henry-Sarabia