Remove get parent/children/sentence generator from Context #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only a few of the classes inheriting from Context implemented these functions, and they are not as clear as explicitly navigating the data model. For example, the Span.get_parent() is less explicit than just saying Span.sentence. Rather than prsent an interface that is not explicit and rarely implemented, this commit just removes it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only a few of the classes inheriting from Context implemented these
functions, and they are not as clear as explicitly navigating the data
model. For example, the Span.get_parent() is less explicit than just
saying Span.sentence. Rather than prsent an interface that is not
explicit and rarely implemented, this commit just removes it.