Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sparse LR support and reorg disc model dir #126

Merged
merged 4 commits into from
Aug 31, 2018
Merged

Add sparse LR support and reorg disc model dir #126

merged 4 commits into from
Aug 31, 2018

Conversation

senwu
Copy link
Collaborator

@senwu senwu commented Aug 30, 2018

No description provided.

@senwu senwu requested a review from lukehsiao August 30, 2018 20:32
lukehsiao
lukehsiao approved these changes Aug 30, 2018
View reviewed changes
Copy link
Contributor

@lukehsiao lukehsiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukehsiao lukehsiao added this to the v0.3.0 milestone Aug 30, 2018
@lukehsiao lukehsiao added enhancement New feature or request clean-up Cleaning up the code or refactoring labels Aug 30, 2018
@senwu senwu merged commit 8483ed7 into master Aug 31, 2018
@senwu senwu deleted the learning_cleanup branch August 31, 2018 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukehsiao lukehsiao lukehsiao approved these changes

Assignees

@senwu senwu

Labels
clean-up Cleaning up the code or refactoring enhancement New feature or request
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@senwu @lukehsiao