Full compatibility for Sumatra custom path #2781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
October 31, 2022 12:07
…ppears in PDF Viewer ComboBox, and making it work with Forward Search and the Configure Inverse Search. 1. Changed isSumatraAvailable in SumatraConversation to a singleton object that checks if Sumatra is available. 2. Added an InputVerifier on the TextField of Custom Sumatra Path that checks the validity of the path, and updates the value of isSumatraAvailable and updates the items in the PDF Viewer ComboBox. 3. Changed the availability in the InternalPdfViewer to a function so that it can be changed during execution. 4. Removed the lines checking if the Sumatra Custom Path was null in addOpenViewerListener so that the user can select which PDF Viewer to open, even if a Sumatra Custom Path is present.
Inverse search action supported for custom SumatraPath Added support for loading custom SumatraPath at startup Redone update of the PdfViewerComboBox to eliminate errors Changed SumatraConversation from a class to an object to better match InternalPdfViewers Added a run function that doesn't wait for a return of the program executed
MisterDeenis
requested review from
HannahSchellekens,
stenwessel,
PHPirates and
slideclimb
as code owners
Qodona warning suppress
PHPirates
reviewed
Nov 18, 2022
src/nl/hannahsten/texifyidea/action/sumatra/ConfigureInverseSearchAction.kt
Outdated
Show resolved
Hide resolved
src/nl/hannahsten/texifyidea/run/latex/ui/LatexSettingsEditor.kt
Outdated
Show resolved
Hide resolved
src/nl/hannahsten/texifyidea/run/latex/ui/LatexSettingsEditor.kt
Outdated
Show resolved
Hide resolved
src/nl/hannahsten/texifyidea/run/sumatra/SumatraConversation.kt
Outdated
Show resolved
Hide resolved
src/nl/hannahsten/texifyidea/run/sumatra/SumatraConversation.kt
Outdated
Show resolved
Hide resolved
added 2 commits
November 20, 2022 16:30
Configure Inverse Search Action back to showing when Sumatra is available. Redone InputVerifier in LatexSettingsEditor to just update the ComboBox and SumatraAvailabilityChecker, no focus changes. Added a file for SumatraAvailabilityChecker. Initialization of SumatraConversation done in execute(). SystemEnvironment updated to be a non-blocking function when necessary.
Moved verification of custom Sumatra path from LatexSettingsEditor InputVerifier to LatexRunConfiguration@checkConfiguration. - Added enableSumatraPath reference in LatexRunConfiguration to make it work. - LatexSettingsEditor edits runConfiguration.enableSumatraPath. - Kept the InputVerifier to update the PDFViewer ComboBox Changed isSumatraPathAvailable to know when a customPath is valid (even if Sumatra is in PATH). - Now returns if Sumatra is available globally (in PATH and custom path) and if Sumatra is available in custom path. - Necessary to make the LatexRunConfiguration@checkConfiguration work. Removed some unnecessary assignation to SumatraAvailabilityChecker. Added some comments.
PHPirates
approved these changes
Nov 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2737
Summary of additions and changes
Added full support when inputting a custom Sumatra path, so that it appears in PDF Viewer ComboBox, and making it work with Forward Search and the Configure Inverse Search.
In brief : when inputting a correct custom Sumatra path (valid path and that contains SumatraPDF.exe), after clicking away from the TextBox, Sumatra automatically appears in the ComboBox of PDF Viewer. And then, making it work with Forward Search and the Configure Inverse Search.
How to test this pull request
Open TeXiFy with only global PATH set to Sumatra (afterwards, do the same with registry keys)
Under LaTeX configuration, under "PDF viewer", "Sumatra" should appear.
Under Tools/LaTeX, option to "Configure Inverse Search" should work as normal.
Forward search should work as normal.
Set no PATH and no registry keys to Sumatra.
Set custom path to Sumatra in Run Configuration to real Sumatra install and click away from the text box.
Under "PDF viewer", "Sumatra" should appear.
Set custom path to Sumatra in Run Configuration to a real folder that doesn't contain Sumatra and click away from the text box.
Under "PDF viewer", "Sumatra" shouldn't appear and an error popup should appear.
Set custom path to Sumatra in Run Configuration to a folder that doesn't exist and click away from the text box.
Under "PDF viewer", "Sumatra" shouldn't appear and an error popup should appear.
Select a "PDF viewer" of your choice under LaTeX configuration, under "PDF viewer".
Run LaTeX project, the PDF viewer selected should open (even if Sumatra is in the Path).