Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extension on input command #2776

Merged
merged 2 commits into from
Nov 14, 2022

Conversation

jojo2357
Copy link
Contributor

Fix #2745

Summary of additions and changes

  • Added input to the list of commands that have an illegal extension.

I also stumbled across a really annoying bug, wherein if the extension was implied before creating a new file, then you can't undo the process, but if an necessary extension was present, then undoing is possible.

I have no idea why.

\input{otherfile.tex} % will drop the tex
\input{otherfile}

Copy link
Collaborator

@PHPirates PHPirates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm yeah it is a bit inconsistent to have \include there but not \input, I don't think there was any reason for that

@jojo2357
Copy link
Contributor Author

simple fixes ftw. i will update the unit test to account for the new expected behavior

@jojo2357 jojo2357 marked this pull request as ready for review November 14, 2022 08:37
@jojo2357
Copy link
Contributor Author

Build failed

How!? I changed two lines 😑

@PHPirates PHPirates enabled auto-merge November 14, 2022 18:44
@PHPirates
Copy link
Collaborator

Looks like a network error or something:

2022-11-14T08:48:03.9130977Z com.intellij.openapi.externalSystem.model.ExternalSystemException: Could not download xz-1.9.jar

I'll trigger a rerun.

@PHPirates PHPirates merged commit 8463f85 into Hannah-Sten:master Nov 14, 2022
@jojo2357 jojo2357 deleted the createfilenotfound branch July 1, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unecessary file extension on CreateFileNotFoundIntention
2 participants