Inline input

[jojo2357]

Fixes #2740

Summary of additions and changes

• Add the ability to inline \include calls and remove the definition file.

TODO

• Create Dialog
• Allow single inline
  Allow Scope selection

How to test this pull request

Create two files, one containing an include of the other.

\documentclass[12pt]{report}
\begin{document}
\include{other}
\end{document}

other.tex

\begin{equation}
math
\end{equation}

[jojo2357]

All tests via gradle passed locally on ubuntu, not sure what is going on there.

[PHPirates]

All tests via gradle passed locally on ubuntu, not sure what is going on there.

If you click through on the red cross, you can see it's the linter that's failed. You can easily fix this by running the ktlintFormat gradle task

[jojo2357]

Oh those are code-style related. I dont see the project having its own formatting rules, or at least the default one makes that gradle task scream red at me. I fixed the issues by hand this time and I would much appreciate not having to do that every time so i can use the shortcut

[PHPirates]

I dont see the project having its own formatting rules

It does, see the .editorconfig file. I think IntelliJ should pick that up automatically, but not sure

[jojo2357]

I have "Enable editorconfig support" ticked, but it still doesnt want to get the indentations right

[PHPirates]

Cool, it works great for me! Thanks so much for adding all the tests :)
Just a few minor things and then it should be good to go.

[jojo2357]

So I think that scope selection is silly, and will only implement it on request, search in comments is silly, and will do so only on request, and I am satisfied with the state of it pending @PHPirates 's review

[PHPirates]

Just one exception which I couldn't reproduce myself: (I think intellij was still in progress with resolving files or something?)

java.lang.IllegalStateException: Inline this requested with no original reference (2)
	at nl.hannahsten.texifyidea.refactoring.inlinefile.LatexInlineFileProcessor.performRefactoring(LatexInlineFileProcessor.kt:52)
	at com.intellij.refactoring.BaseRefactoringProcessor.lambda$doRefactoring$10(BaseRefactoringProcessor.java:520)
	at com.intellij.refactoring.BaseRefactoringProcessor.callPerformRefactoring(BaseRefactoringProcessor.java:574)
	at com.intellij.refactoring.BaseRefactoringProcessor.lambda$doRefactoring$11(BaseRefactoringProcessor.java:519)
	at com.intellij.openapi.application.impl.ApplicationImpl.lambda$runEdtProgressWriteAction$6(ApplicationImpl.java:919)
	at com.intellij.openapi.progress.impl.CoreProgressManager.lambda$runProcess$2(CoreProgressManager.java:190)
...

[jojo2357]

How did you do that? Was it seemingly random and fixed itself?

[PHPirates]

I think I clicked "Inline this and keep file" but not sure

[jojo2357]

Woah I duplicated it

[PHPirates]

Great! Do you want to write the documentation for the wiki as well?

[jojo2357]

Oh, right. theres a wiki. Do you have something in mind? Maybe I could after I make a solution for #2751 to complete the inline concept to the extent that the IDEA space has for other languages?

[PHPirates]

Sure, that's fine

[jojo2357]

Actually I will make the page. I had thought there was code and commits to deal with but that isnt the case so I will write a page to get it started

[PHPirates]

Thanks! It's actually still code and commits though, just a different repo. You can also clone the wiki locally to edit it :)