Fix "Move Section Contents to Seperate File" intention

[jojo2357]

Fix #2724

Summary of additions and changes

• Fixes bug outlined in Move section contents to separate file intention has unexpected bahvior with chapters with sections #2724
• Changed the semantics behind nl.hannahsten.texifyidea.inspections.latex.codestyle.LatexTooLargeSectionInspection#findNextSection(LatexCommands) to require a section/chapter. I don't think it is the best, but I am unsure what else it is used for. If the function is only used to find the next section, from a section, then there will be no issue.
• Note there is no guard to verify that the passed command is actually a valid section. I did this because I wanted to steer away from backsearching for one, since that requires more intimate knowledge of the usage than a basic "Find Usages" will provide.

How to test this pull request

\documentclass[11pt]{article}

\usepackage{amsmath}

\begin{document}

    \chapter{Foo}


    \section{SubFoo}
    Bar

    \subsubsection{SubbFoo}
    Barr

    \section{SubFooToo}


    \chapter{Too}


    \section{SubToo}
    \begin{equation}
        mathisfun
    \end{equation}

\end{document}

To test, take the above test file, and use the Move Section Contents to new File inspection. Perform this on every section and chapter and verify it works as expected. After running the inspection, undo the inspection, then try a second one. After each one works individually, try combinations thereof.

[PHPirates]

Awesome, great work!
I verified manually that it works, could you also add a test to avoid breaking it again in the future?

You can write a test for LatexMoveSectionToFileIntention, similar to the test LatexAddLabelIntentionTest

---

By the way, while reading the code I found another bug (not from this PR), consider this situation in an included file:

\section{Short}
Carefully dealing with the platforms as proceded by Maurice could tempt in governments.
\section{blub}
\begin{center}
    Units can be able to measure the protections, days mailed by performances, and resolve the cabinets since the attentions and the implication.
\end{center}
All correlations cleared by the reported penalties can be traded by the media.

Executing the intention on the second section will result in

\section{Short}
Carefully dealing with the platforms as proceded by Maurice could tempt in governments.
\section{blub}
\input{blub}

\end{center}
All correlations cleared by the reported penalties can be traded by the media.

If you could fix this as well, that would be really great.

[jojo2357]

By the way, while reading the code I found another bug (not from this PR), consider this situation in an included file

Could not replicate the unexpected behavior with the test provided, or some variations thereof.

\documentclass[11pt]{article}
\begin{document}
    \section{Short}
    Carefully dealing with the platforms as proceded by Maurice could tempt in governments.
    \section{blub}
    \begin{center}
        Units can be able to measure the protections, days mailed by performances, and resolve the cabinets since the attentions and the implication.
    \end{center}
    All correlations cleared by the reported penalties can be traded by the media.
\end{document}

If I have misunderstood or otherwise am being dumb, please advise with a complete testcase

I will see about writing tests, and also about when undoing the intention also undoing the file creation

[jojo2357]

Undoing is somehow not supported here. My hunch is that because we go behind IDEA's back with java.io.File#createNewFile and so are impervious to undo's

[PHPirates]

Try without all the extra lines you added, just put in the file what I wrote, and nothing more:

\section{Short}
Carefully dealing with the platforms as proceded by Maurice could tempt in governments.
\section{blub}
\begin{center}
    Units can be able to measure the protections, days mailed by performances, and resolve the cabinets since the attentions and the implication.
\end{center}
All correlations cleared by the reported penalties can be traded by the media.

[PHPirates]

Undoing is somehow not supported here. My hunch is that because we go behind IDEA's back with java.io.File#createNewFile and so are impervious to undo's

I can imagine that we would have to implement the undo ourselves. It does seem recommended to use File: https://plugins.jetbrains.com/docs/intellij/virtual-file.html#how-do-i-create-a-virtual-file

[jojo2357]

Try without all the extra lines you added, just put in the file what I wrote, and nothing more

Verified, thank you

[jojo2357]

I can imagine that we would have to implement the undo ourselves. It does seem recommended to use File

Then what is this doing with PsiFileFactory#createFileFromText(String, FileType, CharSequence)?

[PHPirates]

That's a PsiFile, not a VirtualFile. A PsiFile is like a parsed file: https://plugins.jetbrains.com/docs/intellij/psi-elements.html
You could try that of course if it helps

[jojo2357]

I think I will because i found template files being created that way. If it doesn't work then you wont see it 🙃

[jojo2357]

Attempting to replicate the issue on my windows 10 install. so far unable to do so; seems like the ci needs more ram

[jojo2357]

Fixed the issue you mentioned. Note that I am awaiting your blessing before applying the same undo-ability for the sister intention MoveSeLectionToFile. Turns out that it was possible, albeit with some inspiration from elsewhere

[PHPirates]

The undo works great, amazing! Thanks for adding tests as well.

• When I change the filename in the dialog, the created file will not have that name (it will be the default)
• Now that the file creation code is larger (and better), can you check if you can reuse this for the quickfix from LatexTooLargeSectionInspection?

I can take a look at the memory issue in GH Actions

[jojo2357]

Except for possibly fixing #2745 I believe this to be ready to go.

[jojo2357]

Last commit helps address some of the issues brought up

[jojo2357]

Huh this build failure seems warranted from the log unlike from earlier, gotta look into that then

[PHPirates]

I think everything works now, awesome! Many thanks for fixing the other issues as well :)
(I didn't check but I hope it works on Windows as well)