From 7824374cacfdc7d944c5e2da80de4888a81d7c1b Mon Sep 17 00:00:00 2001 From: Louis Qian Date: Tue, 15 Nov 2022 21:08:49 -0600 Subject: [PATCH 1/3] fixed deprecations `Using 'class' keyword to define a class-constrained protocol` --- HackIllinois/UI/HIErrorView.swift | 2 +- .../UI/TableView/Cells/HIBubbleCell/HIProjectCell.swift | 2 +- HackIllinois/UI/TableView/Cells/HILoginSelectionCell.swift | 2 +- HackIllinois/ViewControllers/HICountdownViewController.swift | 2 +- .../ViewControllers/HILoginSelectionViewController.swift | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/HackIllinois/UI/HIErrorView.swift b/HackIllinois/UI/HIErrorView.swift index bf92ceab..6b3f2ff1 100644 --- a/HackIllinois/UI/HIErrorView.swift +++ b/HackIllinois/UI/HIErrorView.swift @@ -13,7 +13,7 @@ import Foundation import UIKit -protocol HIErrorViewDelegate: class { +protocol HIErrorViewDelegate: AnyObject { func didSelectErrorLogout(_ sender: UIButton) } class HIErrorView: HIView { diff --git a/HackIllinois/UI/TableView/Cells/HIBubbleCell/HIProjectCell.swift b/HackIllinois/UI/TableView/Cells/HIBubbleCell/HIProjectCell.swift index 87324ea2..bed478ca 100644 --- a/HackIllinois/UI/TableView/Cells/HIBubbleCell/HIProjectCell.swift +++ b/HackIllinois/UI/TableView/Cells/HIBubbleCell/HIProjectCell.swift @@ -14,7 +14,7 @@ import Foundation import UIKit import HIAPI -protocol HIProjectCellDelegate: class { +protocol HIProjectCellDelegate: AnyObject { func projectCellDidSelectFavoriteButton(_ projectCell: HIProjectCell) } diff --git a/HackIllinois/UI/TableView/Cells/HILoginSelectionCell.swift b/HackIllinois/UI/TableView/Cells/HILoginSelectionCell.swift index 4f66ae7c..29d970a3 100644 --- a/HackIllinois/UI/TableView/Cells/HILoginSelectionCell.swift +++ b/HackIllinois/UI/TableView/Cells/HILoginSelectionCell.swift @@ -13,7 +13,7 @@ import Foundation import UIKit -protocol HILoginSelectionCellDelegate: class { +protocol HILoginSelectionCellDelegate: AnyObject { } diff --git a/HackIllinois/ViewControllers/HICountdownViewController.swift b/HackIllinois/ViewControllers/HICountdownViewController.swift index 72a99d08..1c1812ad 100644 --- a/HackIllinois/ViewControllers/HICountdownViewController.swift +++ b/HackIllinois/ViewControllers/HICountdownViewController.swift @@ -14,7 +14,7 @@ import Foundation import UIKit import Lottie -protocol HICountdownViewControllerDelegate: class { +protocol HICountdownViewControllerDelegate: AnyObject { func countdownToDateFor(countdownViewController: HICountdownViewController) -> Date? } diff --git a/HackIllinois/ViewControllers/HILoginSelectionViewController.swift b/HackIllinois/ViewControllers/HILoginSelectionViewController.swift index 596536f5..76b0da7b 100644 --- a/HackIllinois/ViewControllers/HILoginSelectionViewController.swift +++ b/HackIllinois/ViewControllers/HILoginSelectionViewController.swift @@ -14,7 +14,7 @@ import Foundation import UIKit import HIAPI -protocol HILoginSelectionViewControllerDelegate: class { +protocol HILoginSelectionViewControllerDelegate: AnyObject { func loginSelectionViewController(_ loginSelectionViewController: HILoginSelectionViewController, didMakeLoginSelection selection: HIAPI.AuthService.OAuthProvider) } From 0b72084d4d202899f2ea194d26b4963959d3bf16 Mon Sep 17 00:00:00 2001 From: Louis Qian Date: Tue, 15 Nov 2022 21:09:52 -0600 Subject: [PATCH 2/3] bumped deployment target to iOS14.0 --- HackIllinois.xcodeproj/project.pbxproj | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/HackIllinois.xcodeproj/project.pbxproj b/HackIllinois.xcodeproj/project.pbxproj index 5735868e..ab40235a 100644 --- a/HackIllinois.xcodeproj/project.pbxproj +++ b/HackIllinois.xcodeproj/project.pbxproj @@ -1063,7 +1063,7 @@ GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE; GCC_WARN_UNUSED_FUNCTION = YES; GCC_WARN_UNUSED_VARIABLE = YES; - IPHONEOS_DEPLOYMENT_TARGET = 11.0; + IPHONEOS_DEPLOYMENT_TARGET = 14.0; MTL_ENABLE_DEBUG_INFO = YES; ONLY_ACTIVE_ARCH = YES; SDKROOT = iphoneos; @@ -1116,7 +1116,7 @@ GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE; GCC_WARN_UNUSED_FUNCTION = YES; GCC_WARN_UNUSED_VARIABLE = YES; - IPHONEOS_DEPLOYMENT_TARGET = 11.0; + IPHONEOS_DEPLOYMENT_TARGET = 14.0; MTL_ENABLE_DEBUG_INFO = NO; SDKROOT = iphoneos; SWIFT_COMPILATION_MODE = wholemodule; From 3399414e3f4a0998d96c282138d6f1703d65eee5 Mon Sep 17 00:00:00 2001 From: Louis Qian Date: Tue, 15 Nov 2022 21:10:10 -0600 Subject: [PATCH 3/3] fixed identifiable protocol conflict --- HackIllinois/UI/Identifiable.swift | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/HackIllinois/UI/Identifiable.swift b/HackIllinois/UI/Identifiable.swift index 7ec996fd..28eaa4ad 100644 --- a/HackIllinois/UI/Identifiable.swift +++ b/HackIllinois/UI/Identifiable.swift @@ -13,9 +13,9 @@ import Foundation import UIKit -protocol Identifiable { - static var identifier: String { get } -} +//protocol Identifiable { +// static var identifier: String { get } +//} extension UITableViewCell: Identifiable { static var identifier: String = String(describing: self)