Enable New Relic again

[paglias]

New Relic has been disabled since we found out ti was the cause of the memory leak.

@gisikw it seems that this might not apply to io.js nodejs/node-v0.x-archive#9064 (comment), we might try to switch to it in future

And also move newrelic.js in subfolder

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

[wraithan]

New Relic node agent engineer here: https://discuss.newrelic.com/t/an-update-on-memory-management-in-node-js-perception-vs-reality/31934 is worth mentioning.

Was looking at this project to contribute while I'm on PTO since it is node-y. I noticed in 8ea69e9 @paglias re-enabled the node agent. Unfortunately it is pretty late in the initialization process. We prefer the agent to be required before anything else. Similar to how require('babel-core/register') in website/src/server.js works, we hook into the module loader to be able to observe your application.

Ideally, we'd be on the line before require('babel-core/register'). Since the babel hook is only concerned with loading new files that contain es6 code, requiring the newrelic agent before the babel hook will not negatively impact babel ability to do it's job to the best of my knowledge, but will make sure any core libs that babel requires get instrumented correctly.

Also to moving newrelic.js to another folder can be achieved using NEW_RELIC_HOME and setting it to the dir that contains the newrelic.js. Another option is to go with pure environment variable based configuration.

[crookedneighbor]

Thanks for this info. We're in the process of upgrading to node v4 so we can re-enable New Relic. The current blocker is mongoose v3, which falls back to the js driver instead of using the native driver. We're going to try to upgrade to mongoose v4 so we can upgrade node as well, but so far have had trouble with stability.

[crookedneighbor]

Closed by #7011