Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Dockerfile to run dev env #937

Closed
tunetheweb opened this issue Jun 29, 2020 · 5 comments · Fixed by #956
Closed

Create Dockerfile to run dev env #937

tunetheweb opened this issue Jun 29, 2020 · 5 comments · Fixed by #956
Assignees
Labels
development Building the Almanac tech stack
Milestone

Comments

@tunetheweb
Copy link
Member

As discussed in #933 (comment) let's set up a Dockerfile to allow easier launching of dev env

@tunetheweb tunetheweb added the development Building the Almanac tech stack label Jun 29, 2020
@tunetheweb tunetheweb added this to the 2019 Backlog milestone Jun 29, 2020
@ibnesayeed
Copy link
Contributor

ibnesayeed commented Jul 4, 2020

What are the latest recommended versions of Python and Node to be used to work with this repo?

@tunetheweb
Copy link
Member Author

Python v3 - should work with latest v3 version
Node v12 - should work with latest v12 version

@ibnesayeed
Copy link
Contributor

When I ran pytest in the container, I saw the following two warnings:

====================================================== test session starts =======================================================
platform linux -- Python 3.8.3, pytest-5.4.3, py-1.9.0, pluggy-0.13.1
rootdir: /app
collected 12 items                                                                                                               

validate_test.py ............                                                                                              [100%]

======================================================== warnings summary ========================================================
validate.py:101
  /app/validate.py:101: DeprecationWarning: invalid escape sequence \s
    accepted_languages = re.findall('(?:^|\s|,)(\w+)', header)

/usr/local/lib/python3.8/site-packages/flask/sessions.py:14
  /usr/local/lib/python3.8/site-packages/flask/sessions.py:14: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated since Python 3.3, and in 3.9 it will stop working
    from collections import MutableMapping

-- Docs: https://docs.pytest.org/en/latest/warnings.html
================================================= 12 passed, 2 warnings in 1.38s =================================================

I can fix the first warning very easily by just making the RegEx a raw string, but the other warning will need update to Flask version. Any suggestions, what should we do about it?

@tunetheweb
Copy link
Member Author

No seen that first error before to be honest. Wonder if it’s due to the version you are running? But if you can see the fix then go for it.

I have seen the second and ignore it as not related to our code and just a warning. Maybe raise a separate issue for that one so we can look at it separately?

@ibnesayeed
Copy link
Contributor

Implemented in #956 and is ready for reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Building the Almanac tech stack
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants