Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate chapters by year #400

Closed
rviscomi opened this issue Nov 9, 2019 · 18 comments · Fixed by #712
Closed

Validate chapters by year #400

rviscomi opened this issue Nov 9, 2019 · 18 comments · Fixed by #712
Assignees
Labels
development Building the Almanac tech stack enhancement New feature or request good first issue Good for newcomers
Milestone

Comments

@rviscomi
Copy link
Member

rviscomi commented Nov 9, 2019

As a follow-up to #392, we shouldn't hardcode the list of chapters. It should support any given year and pull the chapter IDs from the config.

@rviscomi rviscomi added enhancement New feature or request good first issue Good for newcomers development Building the Almanac tech stack labels Nov 9, 2019
@rviscomi rviscomi added this to the Après Ski milestone Nov 9, 2019
@arsenicraghav
Copy link

Is this being worked on by someone ?

@tunetheweb
Copy link
Member

Is this being worked on by someone ?

Nope, not had a chance to look at it yet - go for it!

@arsenicraghav
Copy link

Sure! I will give it a shot. can you assign it ?

@tunetheweb
Copy link
Member

can you assign it ?

Are you not able to grab it yourself by clicking on the "assign yourself" link?

image

@arsenicraghav
Copy link

No, I don't think so. I don't see an option.

@rviscomi
Copy link
Member Author

Need to add @arsenicraghav to the GitHub Almanac team for them to be assignable

@tunetheweb
Copy link
Member

Need to add @arsenicraghav to the GitHub Almanac team for them to be assignable

Well we should add him to there anyway. And to developers. Can you permission me to be able to do that?

However I am able to assign him. So not convinced he needs to be in there. But then that could be cause of my permissions and I can assign anyone? So not sure if it's a permission thing or a UX thing - I think assigning issues in GitHub isn't the most obvious UX and is easily missed!

@arsenicraghav
Copy link

pull the chapter IDs from the config.

@rviscomi do you mean to say from an existing config file ?

@rviscomi
Copy link
Member Author

@tunetheweb
Copy link
Member

Yes, see 2019.json https://github.com/HTTPArchive/almanac.httparchive.org/blob/master/src/config/2019.json

He's already done that as part of #541 .

Think he's asking how he can get access to assign items himself. Just confirmed people in the team can't assign issues to themselves. Can we permission him to be able to do that without full permissions for the repo if we want to keep that locked down a bit for now?

@rviscomi
Copy link
Member Author

I've just given @bazzadp @OBTo and @mikegeyser permission to add members to the Almanac Contributors team and sent @arsenicraghav an invitation to join the Developers subteam.

@tunetheweb
Copy link
Member

I've just given @bazzadp @OBTo and @mikegeyser permission to add members to the Almanac Contributors team and sent @arsenicraghav an invitation to join the Developers subteam.

I can't seem to invite new people :-( Am I doing something stupid?

image

Also don't have permission to add people to sub-teams.

@rviscomi
Copy link
Member Author

That's weird, I don't know why you wouldn't be able to add new members.

image

I've also given you maintainer role on the Developers subteam. Maybe that helps?

@tunetheweb
Copy link
Member

No still can only move people around that are already part of HTTPArchive org.

So I can add anoblet to Alamanac Contributors or Developers as he's part of HTTP Archive Developers, but I can't add people to Almanac who are completely new (like SilentJMA).

@rviscomi
Copy link
Member Author

Ok. There's also a way for people to request to join a team, I think we should try that instead.

@rviscomi
Copy link
Member Author

rviscomi commented Jan 6, 2020

@arsenicraghav any update on this?

@tunetheweb
Copy link
Member

We asked @arsenicraghav to pause working on this in #557 (comment) until we'd figured out #561 - which we haven't figured out yet! 😀

@rviscomi
Copy link
Member Author

rviscomi commented Jan 6, 2020

Thanks for the reminder 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Building the Almanac tech stack enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants