Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find better solution for quick view modals #912

Closed
Guite opened this issue Jan 4, 2017 · 7 comments
Closed

Find better solution for quick view modals #912

Guite opened this issue Jan 4, 2017 · 7 comments
Assignees
@Guite
Labels
architecture frontend
Milestone
0.7.1

Comments

@Guite
Copy link
Owner

Guite commented Jan 4, 2017

Currently the modal windows containing quick views (display action) use the printer theme which is not optimal. First it contains a link list at the bottom and second it causes many conditions in the display template. Thus a better solution is needed. Maybe using PlainResponse.
@Guite Guite added this to the 0.7.1 milestone Jan 4, 2017
@Guite Guite self-assigned this Jan 4, 2017
@Guite
Copy link
Owner Author

Guite commented Jan 7, 2017

@craigh

  1. I did a small test with PlainResponse and it seems that this is wrapped in the theme, too. What is the preferred way to get an output without any theme?
  2. A printer theme is a legacy concept, isn't it? Today print views are done using @media print { ... } in css. Maybe we should remove the printer theme from the master branch of the core?

@rallek
Copy link

rallek commented Jan 7, 2017

The current concept is so easy to use...

@Guite
Copy link
Owner Author

Guite commented Jan 7, 2017

okay... it doesn't hurt us to keep the printer theme :p

@craigh
Copy link

craigh commented Jan 7, 2017

PlainResponse is the correct way. Printer Theme is very not right. If it isn't working, then that would be a core bug

@craigh
Copy link

craigh commented Jan 7, 2017

it sounds a little like zikula/core#3087

@Guite
Copy link
Owner Author

Guite commented Jan 7, 2017

I will do a more thorough test.

@Guite
Copy link
Owner Author

Guite commented Jan 7, 2017

PlainResponse works at /search/opensearch so it seems to work in general.

@Guite Guite closed this as completed in 355e8ef Jan 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Guite Guite

Labels
architecture frontend
Projects
None yet
Milestone
0.7.1
Development

No branches or pull requests
3 participants
@Guite @craigh @rallek