You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Since Store is a low-level API, we should be able to override its members. I've made PR #61 for this.
I came across the need for overriding InnerDispatch when trying to subclass Store to create a kind of ObservableActionStore that surfaces a property IObservable<IAction> Actions. This should only be fired (OnNext called) when the action reaches the inner dispatch, but to override InnerDispatch it needs to be protected virtual.
Edit, see #63 for a better solution to this paragraph. In addition, we might consider implementing IObservable Actions { get; } in the base store. As far as I can see, the functionality would be orthogonal to everything we currently have. With the possible exception of the return value of Dispatch, but maybe an observable of actions would be a more robust solution to whatever needs are currently being served by this return value?
Since
Store
is a low-level API, we should be able to override its members. I've made PR #61 for this.I came across the need for overriding
InnerDispatch
when trying to subclassStore
to create a kind ofObservableActionStore
that surfaces a propertyIObservable<IAction> Actions
. This should only be fired (OnNext
called) when the action reaches the inner dispatch, but to overrideInnerDispatch
it needs to beprotected virtual
.Edit, see #63 for a better solution to this paragraph.
In addition, we might consider implementingIObservable Actions { get; }
in the base store. As far as I can see, the functionality would be orthogonal to everything we currently have. With the possible exception of the return value ofDispatch
, but maybe an observable of actions would be a more robust solution to whatever needs are currently being served by this return value?@dcolthorp might have some input here.
The text was updated successfully, but these errors were encountered: