Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make InnerDispatch protected virtual #60

Open
cmeeren opened this issue Apr 3, 2017 · 0 comments
Open

Make InnerDispatch protected virtual #60

cmeeren opened this issue Apr 3, 2017 · 0 comments

Comments

@cmeeren
Copy link

cmeeren commented Apr 3, 2017

Since Store is a low-level API, we should be able to override its members. I've made PR #61 for this.

I came across the need for overriding InnerDispatch when trying to subclass Store to create a kind of ObservableActionStore that surfaces a property IObservable<IAction> Actions. This should only be fired (OnNext called) when the action reaches the inner dispatch, but to override InnerDispatch it needs to be protected virtual.

Edit, see #63 for a better solution to this paragraph. In addition, we might consider implementing IObservable Actions { get; } in the base store. As far as I can see, the functionality would be orthogonal to everything we currently have. With the possible exception of the return value of Dispatch, but maybe an observable of actions would be a more robust solution to whatever needs are currently being served by this return value?

@dcolthorp might have some input here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant