From 5b63bc2fb7f714f7510543af0c0c3235157bccaa Mon Sep 17 00:00:00 2001 From: Ralf Jung Date: Wed, 5 May 2021 13:53:42 +0200 Subject: [PATCH] add 'waiting-for-review' incantation to main contrib page (#1124) --- src/contributing.md | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/contributing.md b/src/contributing.md index abe1bb8390b98..02ae1159c647a 100644 --- a/src/contributing.md +++ b/src/contributing.md @@ -147,8 +147,12 @@ rebase when bringing the latest changes from the master branch to your feature branch. Also, please make sure that fixup commits are squashed into other related commits with meaningful commit messages. -If you encounter merge conflicts, your PR will get marked as `S-waiting-on-author`. -When you resolve them, you should use `@rustbot` to mark it as `S-waiting-on-review`. +If you encounter merge conflicts or when a reviewer asks you to perform some +changes, your PR will get marked as `S-waiting-on-author`. When you resolve +them, you should use `@rustbot` to mark it as `S-waiting-on-review`: + + @rustbot label -S-waiting-on-author +S-waiting-on-review + See [this chapter][labeling] for more details. GitHub allows [closing issues using keywords][closing-keywords]. This feature