Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculation creates faulty query #138

Closed
alexl04 opened this issue Aug 30, 2023 · 3 comments
Closed

Calculation creates faulty query #138

alexl04 opened this issue Aug 30, 2023 · 3 comments
Milestone

Comments

@alexl04
Copy link

alexl04 commented Aug 30, 2023

Grafana 10.01/10.02 [Linux]
osisoftpi Grafana plugin 4.2
osisoftpi WEB API 2022 patch 1

Issues:

  1. Calculation does not work in combination with Summary Period. Issue present in all plugin versions.
  2. Plugin sends an incorrect query to PI if we add a Calculation in the query. See screenshots. It seems that the dashboard time-window is divided into multiple smaller time-windows and then inserted into the query to PI. This results in a query with fewer data points than expected by the Query settings in Grafana. Issue is seen from plugin version 4+. With version 3 this was no issue.
wrong good
@complacentsee
Copy link
Contributor

complacentsee commented Sep 1, 2023

I believe the default value is defined as 40 calculated values in version 4 instead of being dynamically calculated.

@coderReview I believe I stumbled onto both issues when testing the backend version and have the fix in there.

@alexl04
Copy link
Author

alexl04 commented Sep 5, 2023

I believe the default value is defined as 40 calculated values in version 4 instead of being dynamically calculated.

@coderReview I believe I stumbled onto both issues when testing the backend version and have the fix in there.

@complacentsee Awesome work!
@coderReview Will the fix be included in the next available version? Looking forward to the fix. Much appreciated. We make use of this plugin a lot. In short, without this plugin it becomes a hassle to dashboard data from PI. If you ask me it would be logic for Grafana to include this plugin into Grafana by default.

@coderReview
Copy link
Collaborator

I have added a fix in version 5.0.0. It's actually defaults to recorded values.

@coderReview coderReview added this to the Version 5.0.0 milestone Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants