Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace legacy layer types with nodes #768

Closed
Tracked by #144
Keavon opened this issue Aug 28, 2022 · 2 comments · Fixed by #1155
Closed
Tracked by #144

Replace legacy layer types with nodes #768

Keavon opened this issue Aug 28, 2022 · 2 comments · Fixed by #1155
Assignees
Labels
Architecture Involves architecture or engineering work or discussion
Milestone

Comments

@Keavon
Copy link
Member

Keavon commented Aug 28, 2022

Task: Switch LayerDataType struct values to nodes

#[derive(Debug, Clone, PartialEq, Deserialize, Serialize)]
/// Represents different types of layers.
pub enum LayerDataType {
	/// A layer that wraps a [FolderLayer] struct.
	Folder(FolderLayer),
	/// A layer that wraps a [ShapeLayer] struct.
	Shape(ShapeLayer),
	/// A layer that wraps a [TextLayer] struct.
	Text(TextLayer),
	/// A layer that wraps an [ImageLayer] struct.
	Image(ImageLayer),
        Imaginate(ImaginateLayer),
}

FolderLayer, ShapeLayer, TextLayer, and ImageLayer live in /graphene. Each of these structs (saving FolderLayer for another issue) should be converted into nodes using the new node system in /node-graph.


Questions for @TrueDoctor:

  • How does this approach relate to the separation between "document graph" and "proto graph"?
  • Can we continue to reference the other data structures defined in /graphene which are used by those three (four) structs once they are ported to nodes in /node-graph?
  • Where do these new vector-editing-specific nodes go in the node graph folder structure?
  • Any other things to be aware of?
@TrueDoctor
Copy link
Member

These would be document graph nodes so we are kinda blocked by my work on document nodes there

@0HyperCube 0HyperCube removed their assignment Aug 28, 2022
@Keavon
Copy link
Member Author

Keavon commented Aug 28, 2022

@TrueDoctor Ok, thanks for clarifying that. Would you be able to meet with @0HyperCube and me soon to design that?

@Keavon Keavon added the Architecture Involves architecture or engineering work or discussion label Aug 28, 2022
@Keavon Keavon changed the title Switch LayerDataType struct values to nodes Replace existing layer data structure with pure nodes Oct 23, 2022
@Keavon Keavon added Blocked and removed Available labels Jan 15, 2023
@Keavon Keavon changed the title Replace existing layer data structure with pure nodes Replace existing layer types with nodes Jan 28, 2023
@0HyperCube 0HyperCube moved this to Medium-Term in Task Board Mar 18, 2023
@Keavon Keavon changed the title Replace existing layer types with nodes Replace legacy layer types with nodes Apr 26, 2023
@Keavon Keavon moved this from Medium-Term to In-Progress in Task Board Apr 26, 2023
@github-project-automation github-project-automation bot moved this from In-Progress to Completed This Sprint in Task Board Apr 27, 2023
@Keavon Keavon added this to the Sprint 25 milestone May 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Architecture Involves architecture or engineering work or discussion
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants