Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the layer tree show duplicate branches where they are used multiple times in the graph #2217

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mTvare6
Copy link
Contributor

@mTvare6 mTvare6 commented Jan 23, 2025

Fixes #2153

@mTvare6 mTvare6 marked this pull request as draft January 23, 2025 10:51
@mTvare6 mTvare6 force-pushed the recursive-relations-experiment branch 3 times, most recently from bf6a02b to 776dc35 Compare January 25, 2025 07:35
@Keavon Keavon changed the title Remove the checks if layer is already present in graph to allow multiple instances(Experimental) Make the layer tree show duplicate branches where they are used multiple times in the graph Jan 25, 2025
@mTvare6 mTvare6 force-pushed the recursive-relations-experiment branch from 776dc35 to f26b1b6 Compare January 30, 2025 09:29
@Keavon
Copy link
Member

Keavon commented Feb 6, 2025

!build

Copy link

github-actions bot commented Feb 6, 2025

📦 Build Complete for 79f5bee
https://420d13e4.graphite.pages.dev

@Keavon
Copy link
Member

Keavon commented Feb 6, 2025

With the following graph setup, upon closing the node graph or switching to the Select tool, we enter an infinite loop.

capture

Here's what the profiler shows is running in the infinite loop.

capture

@Keavon
Copy link
Member

Keavon commented Feb 6, 2025

If, during testing, you end up with the document autosaved and the browser freezing, you may have trouble opening localhost again after closing then revisiting the localhost:8080 tab. If that occurs, you may need to quickly use F12 to open dev tools and expand IndedexDB storage to clear it, potentially fast enough before the infinite loop begins rendering dev tools unresponsive. Here's how to clear it:

Chrome:

capture

Firefox:

capture

@mTvare6
Copy link
Contributor Author

mTvare6 commented Feb 6, 2025

Seems to be the case that changing order works fine:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Layers panel doesn't show expandable children for the lower layer, only the top layer
2 participants