Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[testing] Add integration test which uses helm hooks #8063

Closed
aaron-prindle opened this issue Nov 9, 2022 · 1 comment · Fixed by #9100
Closed

[testing] Add integration test which uses helm hooks #8063

aaron-prindle opened this issue Nov 9, 2022 · 1 comment · Fixed by #9100
Assignees
@ericzzzzzzz
Labels
area/testing Issues concerning the testing phase of Skaffold kind/todo implementation task/epic for the skaffold team
Milestone
fix-it

Comments

@aaron-prindle
Copy link
Contributor

aaron-prindle commented Nov 9, 2022 •
edited
Loading

There is a regression in skaffold v2.0.0 in which helm hooks no longer work as hook manifests are not passed properly when using --post-renderer atm. This issue tracks adding an integration test with an example that uses helm hooks functionality s.t. such a regression is caught in the future

Related: #7989 and helm/helm#7891
@aaron-prindle aaron-prindle added area/testing Issues concerning the testing phase of Skaffold kind/todo implementation task/epic for the skaffold team labels Nov 9, 2022
@aaron-prindle aaron-prindle added this to the skaffold-v2-backlog milestone Nov 9, 2022
@aaron-prindle aaron-prindle changed the title [testing] Add integration tests which use helm hooks [testing] Add integration test which uses helm hooks Nov 9, 2022
@aaron-prindle
Copy link
Contributor Author

The actual root cause of the issue was not related to helm hooks. Skaffold uses helm template + --set="key=value" to replace values and this goes into hooks. Skaffold's post-renderer only adds labels for helm. AS such, there is no issue w/ helm hooks + skaffold (it was another issue with our value replacements). It still makes sense to have wider integration test coverage for helm features though so keeping this open

@ericzzzzzzz ericzzzzzzz modified the milestones: skaffold-backlog, fix-it Jul 12, 2023
@ericzzzzzzz ericzzzzzzz self-assigned this Sep 27, 2023
@ericzzzzzzz ericzzzzzzz mentioned this issue Sep 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ericzzzzzzz ericzzzzzzz

Labels
area/testing Issues concerning the testing phase of Skaffold kind/todo implementation task/epic for the skaffold team
Projects
None yet
Milestone
fix-it
Development

Successfully merging a pull request may close this issue.

feat: Support post-renderer for helm deployer. ericzzzzzzz/skaffold
2 participants
@aaron-prindle @ericzzzzzzz