Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor to reduce duplicate code #262

Closed
6 tasks done
TadCordle opened this issue May 9, 2018 · 4 comments
Closed
6 tasks done

Refactor to reduce duplicate code #262

TadCordle opened this issue May 9, 2018 · 4 comments
Labels
area/jib-core area/jib-gradle-plugin area/jib-maven-plugin

Comments

@TadCordle
Copy link
Contributor

TadCordle commented May 9, 2018 •
edited
Loading

Refactor to reduce copy/pasted code between the following files:
@TadCordle TadCordle changed the title Refactor BuildDockerSteps and BuildImageSteps to reduce duplicate code Refactor to reduce duplicate code May 10, 2018
@TadCordle TadCordle mentioned this issue May 10, 2018
Merged
This was referenced May 10, 2018
Merged
Merged
This was referenced May 17, 2018
Merged
Merged
@coollog coollog mentioned this issue May 18, 2018
Closed
15 tasks
This was referenced May 21, 2018
Merged
Merged
@coollog
Copy link
Contributor

coollog commented May 22, 2018

Btw I'm done messing with BuildImageSteps and BuildDockerSteps so we can refactor those two now.

@coollog
Copy link
Contributor

coollog commented May 22, 2018

Oh actually, hold off on that for a bit.

@coollog
Copy link
Contributor

coollog commented May 22, 2018

Gonna do this first: #305

@TadCordle
Copy link
Contributor Author

Cool, if you want to take those you can, I'm working on the two ProjectProperties right now.

This was referenced May 22, 2018
Merged
Merged
Merged
@TadCordle TadCordle mentioned this issue May 23, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/jib-core area/jib-gradle-plugin area/jib-maven-plugin
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TadCordle @coollog