-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version/Tag distroless images #214
Comments
@saturnism can you share how you would suggest the tagging be done? |
similar to https://hub.docker.com/_/openjdk/ we should at least call out 8u???, and always update 8 to point to the latest of 8u... |
quick ping. |
Currently it is built off of Debian Stable so only those packages would be used but you can use the cc image and drop on your JDK of choice in a multi-stage docker or update the bazel build in your own bazel setup. |
Hmm.. I'm not sure I'm following how this relates to tagging the container images. The issue is that untagged images aren't stable, and relaying on |
Can you explain what you mean by stable? All images are tagged with the git commit they were built at, and are also available by their sha256 digest. |
As a user I would like to know exactly what version of java my code is running with. The latest tag does not tell me if it's JDK 8 update 171 or JDK 8 update 131 or some other value. It makes my build unstable since every time I run it I might end up with a different version of the java distroless image. Once you add support for Java 11 I assume latest will point at java 11 not 8 so my builds will break because I am using the wrong version of java with my app. |
Where is the list of git commit tags? and is there a documentation on which git commit represents which JDK build? a tag is helpful to expose this in a readable and easily understood way. |
Adding my support for this. In addition to providing a quick, easy way to determine which version of X we're getting, tags provide a way to pin to a specific version. Otherwise, you're always implicitly pulling the Brief addendum, root cause possibly being my docker-fu is lacking: Because these images are not hosted on the public registry and because the Docker CLI doesn't seem to implement a command that enumerates the tags for an image, I've had a difficult time trying to determine what tags actually available. Specific to the Node image: It would be extremely helpful to indicate the Node version used here, especially considering that none of the source files under that directory make any reference to the Node version being used. I did finally find it here. 😕 |
@darkobits just visit https://gcr.io/distroless/java (or https://gcr.io/distroless/nodejs) — Google Container Registry will provide a nice UI with available images and tags. |
Brilliant! 😍 |
There have been quite a few changes since this issue was created. I'll collect the different requests here with pointers to follow-on issues.
We now have and maintain :8 and :11 tags, and the images are now branded with their JRE build information in the
We're now publishing a #276 requests exposing this information on image labels too, but we need to come up with a label naming scheme.
Since Docker tags aren't immutable they aren't really suitable to pin to a specific version. If you want reproducibility, you really need to reference the SHA1 as the distroless base image updates fairly often, which cascades through the other images. So the original request is to tag images with their JRE build. |
related to this conversation: |
How can I know which one is java 15 from '/gcr/images/distroless/global/java'? |
@tothadam98 There is no java 15 but there are java 17, java 11 and java 8. |
For Java image, it's
gcr.io/distroless/java
, but doesn't have any reference to which Java version. This is important to be tagged.The text was updated successfully, but these errors were encountered: