feat: Cloud Run Jobs sub module #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bharathkkb
requested review from
a team,
prabhu34,
anamer and
mitchelljamie
as code owners
bharathkkb
commented
Mar 6, 2023
| @@ -25,6 +25,7 @@ steps: | |||
| - 'TF_VAR_seed_project_id=$_SFB_SEED_PROJECT_ID' | |||
| - 'TF_VAR_domain=test.infra.cft.tips' | |||
| - 'TF_VAR_resource_names_suffix=$SHORT_SHA' | |||
| allowFailure: true | |||
There was a problem hiding this comment.
@amandakarina I noticed that PRs were failing for tests on secure foundation. I added this for now so as not to block other PRs.
There was a problem hiding this comment.
hey Bharath, did we have any modifications in the Foundation deployment?
The error is always the same?
TestSecureCloudRun 2023-03-06T19:12:18Z command.go:185: Error: Error waiting to create Service: resource is in failed state "Ready:False", message: Waiting to reconcile Route. Resource readiness deadline exceeded.
TestSecureCloudRun 2023-03-06T19:12:18Z command.go:185:
TestSecureCloudRun 2023-03-06T19:12:18Z command.go:185: with module.secure_cloud_run.module.secure_cloud_run.module.cloud_run_core.module.cloud_run.google_cloud_run_service.main,
TestSecureCloudRun 2023-03-06T19:12:18Z command.go:185: on ../../../main.tf line 22, in resource "google_cloud_run_service" "main":
TestSecureCloudRun 2023-03-06T19:12:18Z command.go:185: 22: resource "google_cloud_run_service" "main" {
TestSecureCloudRun 2023-03-06T19:12:18Z command.go:185:
TestSecureCloudRun 2023-03-06T19:12:18Z retry.go:99: Returning due to fatal error: FatalError{Underlying: error while running command: exit status 1;
Error: Error waiting to create Service: resource is in failed state "Ready:False", message: Waiting to reconcile Route. Resource readiness deadline exceeded.There was a problem hiding this comment.
hey Bharath, I think this line can be removed after the fix, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new Cloud Run Jobs sub module with direct trigger functionality.