Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: annotations serverside diffs #92

Merged
merged 3 commits into from
Mar 14, 2023
Merged

fix: annotations serverside diffs #92

merged 3 commits into from
Mar 14, 2023

Conversation

bharathkkb
Copy link
Member

fixes #91

prabhu34

This comment was marked as outdated.

Copy link
Collaborator

@prabhu34 prabhu34 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error waiting to create Service: resource is in failed state "Ready:False", message: Waiting to reconcile Route. Resource readiness deadline exceeded.

@Klaitos
Copy link

Klaitos commented Feb 21, 2023

Any chance to get this merged ? The operation id label is annoying. Thanks guys !

@amandakarina
Copy link
Collaborator

/gcbrun

@bharathkkb
Copy link
Member Author

Looks like tests passed after Amanda's fix.

@bharathkkb bharathkkb merged commit af92754 into main Mar 14, 2023
@bharathkkb bharathkkb deleted the bharathkkb-patch-2 branch March 14, 2023 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add internal lifecycle for annotations
5 participants