Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update display metadata #288

Merged
merged 3 commits into from
Jan 15, 2025
Merged

fix: update display metadata #288

merged 3 commits into from
Jan 15, 2025

Conversation

q2w
Copy link
Collaborator

@q2w q2w commented Jan 15, 2025

No description provided.

@q2w q2w marked this pull request as ready for review January 15, 2025 17:23
@q2w q2w requested review from anamer, prabhu34 and a team as code owners January 15, 2025 17:23
apeabody
apeabody approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to code as fix as this changes TF (although not functionally) and to trigger a release.

@q2w q2w changed the title chore: update display metadata fix: update display metadata Jan 15, 2025
@q2w q2w merged commit 2e568b3 into GoogleCloudPlatform:main Jan 15, 2025
4 checks passed
@release-please release-please bot mentioned this pull request Jan 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apeabody apeabody apeabody approved these changes

@anamer anamer Awaiting requested review from anamer anamer is a code owner

@prabhu34 prabhu34 Awaiting requested review from prabhu34 prabhu34 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@q2w @apeabody