Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add connection metadata for incoming connection from GCS and fix typo in v2/main.tf #235

Merged
merged 2 commits into from
Sep 3, 2024
Merged

fix: Add connection metadata for incoming connection from GCS and fix typo in v2/main.tf #235

merged 2 commits into from
Sep 3, 2024

Conversation

q2w
Copy link
Collaborator

@q2w q2w commented Sep 2, 2024 •
edited by bharathkkb
Loading

This PR makes below changes,

  1. Fixes typo in v2/main.tf for creating GCS volume fixes Typos in v2 setup for GCS #230
  2. Adds new connection metadata coming from GCS
  3. Adds new connection metadata coming from Mysql (similar to existing postgresql module)

@q2w q2w changed the title Add connection metadata for incoming connection from GCS and fix typo… chore: Add connection metadata for incoming connection from GCS and fix typo in v2/main.tf Sep 2, 2024
@q2w q2w requested a review from bharathkkb September 2, 2024 09:10
@q2w
Copy link
Collaborator Author

q2w commented Sep 2, 2024

/gcbrun

@q2w q2w marked this pull request as ready for review September 2, 2024 12:20
@q2w q2w requested review from prabhu34, anamer, gtsorbo and a team as code owners September 2, 2024 12:20
@q2w
Copy link
Collaborator Author

q2w commented Sep 3, 2024

/gcbrun

bharathkkb
bharathkkb approved these changes Sep 3, 2024
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@bharathkkb bharathkkb changed the title chore: Add connection metadata for incoming connection from GCS and fix typo in v2/main.tf fix: Add connection metadata for incoming connection from GCS and fix typo in v2/main.tf Sep 3, 2024
@bharathkkb bharathkkb enabled auto-merge (squash) September 3, 2024 19:15
@bharathkkb bharathkkb merged commit d359e7e into GoogleCloudPlatform:main Sep 3, 2024
4 checks passed
@release-please release-please bot mentioned this pull request Aug 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharathkkb bharathkkb bharathkkb approved these changes

@prabhu34 prabhu34 Awaiting requested review from prabhu34 prabhu34 is a code owner

@anamer anamer Awaiting requested review from anamer anamer is a code owner

@gtsorbo gtsorbo Awaiting requested review from gtsorbo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typos in v2 setup for GCS
2 participants
@q2w @bharathkkb