Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Various fixes to volumes and volume mounts #213

Merged
merged 8 commits into from
Oct 1, 2024
Merged

fix: Various fixes to volumes and volume mounts #213

merged 8 commits into from
Oct 1, 2024

Conversation

vale-qb
Copy link
Contributor

@vale-qb vale-qb commented Jun 25, 2024

Fixing 3 issues with volumes and volume mounts:

  1. making secret optional, in case one wants to use just database, cloud storage or nfs
  2. changing cloud_sql_instance.instances type to list of strings, to match the signature of the underlying google_cloud_run_v2_service
  3. fixing the values access in volumes, for gcs and nfs

@vale-qb vale-qb requested review from prabhu34, anamer, gtsorbo and a team as code owners June 25, 2024 13:59
@vale-qb
Copy link
Contributor Author

vale-qb commented Jul 8, 2024

Hi. Any update on this, please?

@apeabody
Copy link
Contributor

apeabody commented Aug 5, 2024

/gcbrun

@apeabody
Copy link
Contributor

apeabody commented Aug 5, 2024

/gcbrun

@vale-qb
Copy link
Contributor Author

vale-qb commented Sep 30, 2024

Hi. Any updates, please?

@apeabody
Copy link
Contributor

apeabody commented Oct 1, 2024

/gcbrun

apeabody
apeabody approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @vale-qb!

@apeabody apeabody merged commit 3f922b8 into GoogleCloudPlatform:main Oct 1, 2024
4 checks passed
@release-please release-please bot mentioned this pull request Oct 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apeabody apeabody apeabody approved these changes

@prabhu34 prabhu34 Awaiting requested review from prabhu34 prabhu34 is a code owner

@anamer anamer Awaiting requested review from anamer anamer is a code owner

@gtsorbo gtsorbo Awaiting requested review from gtsorbo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vale-qb @apeabody