Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adds extra apis variable #119

Conversation

amandakarina
Copy link
Collaborator

@amandakarina amandakarina commented May 10, 2023

Adds missing api at network project

@amandakarina amandakarina requested review from a team, prabhu34 and gtsorbo as code owners May 10, 2023 16:14
@amandakarina amandakarina changed the title fix: adds servicenetworking.googleapis.com in network project fix: adds extra apis variable May 11, 2023
@prabhu34
Copy link
Collaborator

@amandakarina There are lint errors. I did not understand the use of additional variables for enabling APIs. However, I'm good if someone from the team has peer reviewed. Thanks!

@amandakarina
Copy link
Collaborator Author

@amandakarina There are lint errors. I did not understand the use of additional variables for enabling APIs. However, I'm good if someone from the team has peer reviewed. Thanks!

Hey @prabhu34

The linting errors are in another sub-module, the jobs-exec, not affected by this PR.

I've fixed the linting errors in this PR.

@gtsorbo gtsorbo merged commit 730fd95 into GoogleCloudPlatform:main May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants