Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: check for exception when parsing pub sub response and return it (#2696) #3091

Merged
merged 1 commit into from
Aug 5, 2024
Merged

fix: check for exception when parsing pub sub response and return it (#2696) #3091

merged 1 commit into from
Aug 5, 2024

Conversation

ldetmer
Copy link
Contributor

@ldetmer ldetmer commented Jul 30, 2024 •
edited
Loading

@conventional-commit-lint-gcf Conventional Commit Lint GCF
Copy link

conventional-commit-lint-gcf bot commented Jul 30, 2024 •
edited
Loading

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@ldetmer ldetmer changed the title catch and return exception in the case there is an issue parsing pub … fix: pubsub template hanging if exception is thrown when paring response Jul 30, 2024
@ldetmer ldetmer changed the title fix: pubsub template hanging if exception is thrown when paring response fix: pubsub template hanging if exception is thrown when paring response (#2696) Jul 30, 2024
@ldetmer ldetmer force-pushed the bugfix-329471140 branch 2 times, most recently from 7fd6bf2 to 0fea8e2 Compare July 31, 2024 18:23
@ldetmer ldetmer marked this pull request as ready for review August 1, 2024 14:42
@ldetmer ldetmer requested a review from a team as a code owner August 1, 2024 14:42
@ldetmer ldetmer changed the title fix: pubsub template hanging if exception is thrown when paring response (#2696) fix: pubsub template api hanging if exception is thrown when parsing response (#2696) Aug 1, 2024
@ldetmer ldetmer changed the title fix: pubsub template api hanging if exception is thrown when parsing response (#2696) fix: pubsub subscriber api hanging if exception is thrown when parsing message (#2696) Aug 1, 2024
@ldetmer ldetmer changed the title fix: pubsub subscriber api hanging if exception is thrown when parsing message (#2696) fix: check for exception when parsing pub sub response and return it (#2696) Aug 2, 2024
@burkedavison
Copy link
Member

LGTM once Tomo gives the thumbs up.

@ldetmer ldetmer force-pushed the bugfix-329471140 branch 2 times, most recently from bd31466 to 2b8cf9a Compare August 2, 2024 17:53
@ldetmer ldetmer requested a review from suztomo August 2, 2024 17:55
suztomo
suztomo approved these changes Aug 2, 2024
View reviewed changes
Copy link
Contributor

@suztomo suztomo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you add a unit to the timeout and them merge this?

.../test/java/com/google/cloud/spring/pubsub/core/subscriber/PubSubSubscriberTemplateTests.java Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Aug 2, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ldetmer ldetmer merged commit d605691 into main Aug 5, 2024
76 checks passed
@ldetmer ldetmer deleted the bugfix-329471140 branch August 5, 2024 14:32
@release-please release-please bot mentioned this pull request Jul 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suztomo suztomo suztomo approved these changes

@burkedavison burkedavison burkedavison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ldetmer @burkedavison @suztomo