Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pub / Sub list_subscriptions_in_topic uses wrong method #1305

Closed
dhermes opened this issue Jan 8, 2018 · 2 comments
Closed

Pub / Sub list_subscriptions_in_topic uses wrong method #1305

dhermes opened this issue Jan 8, 2018 · 2 comments
Assignees
@andrewsg
Labels
Data Analytics / ML / IoT

Comments

@dhermes
Copy link
Contributor

dhermes commented Jan 8, 2018

In which file did you encounter the issue?

python-docs-samples/pubsub/cloud-client/subscriber.py

Line 30 in 06453e4

def list_subscriptions_in_topic(project, topic_name):

Describe the issue

publisher.list_topic_subscriptions() should be used rather than subscriber.list_subscriptions()

See googleapis/google-cloud-python#4426
@dhermes dhermes mentioned this issue Jan 8, 2018
Closed
@theacodes
Copy link
Contributor

@andrewsg can you take this on?

@theacodes theacodes added the bug label Jan 8, 2018
@andrewsg
Copy link
Member

Problem was solved but bug wasn't closed. Closing now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrewsg andrewsg

Labels
Data Analytics / ML / IoT
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@theacodes @dhermes @andrewsg @nnegrey