PubSub: Prevent unhandled background error on SPM shutdown #8111
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6130.
This PR fixes errors in background threads that might happen on user-initiated streaming pull shutdown, i.e. cancelling the future returned by the
subscriber.subscribe()
call.How to test
Steps to reproduce:
logging.DEBUG
. FWIW, I used the following config during development:Actual result (before the fix):
An error can be observed in
Thread-CallbackRequestDispatcher
(the one listed under "Stacktrace 2" in the issue description). The issue is reproducible with high consistency:Expected result (after the fix):
The StreamingPullManager gets shut down cleanly, i.e. without the error reported. There might be a stacktrace of the
Cancelled
exception produced byapi_core.bidi
, but that is a harmless "expected exception":