Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-generate library using speech/synth.py #5915

Merged
merged 2 commits into from
Sep 11, 2018
Merged

Re-generate library using speech/synth.py #5915

merged 2 commits into from
Sep 11, 2018

Conversation

danoscarmike
Copy link
Contributor

Incorporate new changes to Speech v1 per latest commit to googleapis.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 11, 2018
@danoscarmike
Copy link
Contributor Author

@theacodes seems to have overwritten the README pretty heavily -- reverting from Beta to Alpha -- that's not expected is it?

@theacodes
Copy link
Contributor

@danoscarmike probably not. We can write a quick replace in synth.py to fix that, something like:

s.replace('README.rst', '`Alpha`', '`Beta`')

@danoscarmike
Copy link
Contributor Author

Done and regenerated. PTAL.

@theacodes
Copy link
Contributor

Thanks for doing this, @danoscarmike!

@theacodes theacodes merged commit 413f8e7 into master Sep 11, 2018
@theacodes theacodes deleted the dan_speech branch September 11, 2018 04:11
@tseaver
Copy link
Contributor

tseaver commented Sep 11, 2018

@theacodes We likely want to work out how synth works for docs for manual veneers: having it step on README.rst, docs/index.rst, etc. is probably not what we want in those packages.

@theacodes
Copy link
Contributor

@tseaver the solution there is to selectively copy files and use replacements as needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants