-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add grpcio-gcp dependency for cloud spanner #5904
Add grpcio-gcp dependency for cloud spanner #5904
Conversation
Making /cc @snehashah16 |
I'm going to send a PR to fix the wheel situation, then we can merge this. The repo is at https://github.com/GoogleCloudPlatform/grpc-gcp-python |
spanner/setup.py
Outdated
@@ -30,7 +30,7 @@ | |||
release_status = 'Development Status :: 5 - Production/Stable' | |||
dependencies = [ | |||
'google-cloud-core<0.29dev,>=0.28.0', | |||
'google-api-core[grpc]<2.0.0dev,>=1.1.0', | |||
'google-api-core[grpc, grpcio-gcp]<2.0.0dev,>=1.1.0', |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Universal wheel PR: GoogleCloudPlatform/grpc-gcp-python#99 |
Updated the min version for api_core and published universal wheel package for grpcio-gcp. As for the release version for api-core and cloud-spanner, should I bump their versions now in this PR, or leave them for you guys when they are ready to release? |
No, releasetool will handle that.
…On Mon, Sep 10, 2018 at 12:56 PM Weiran Fang ***@***.***> wrote:
Should I bump api core and cloud spanner versions in this PR, or leave
them for you guys when they are ready to release?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#5904 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAPUc8TPEz-8E-LkEltLeWhBoikjElhRks5uZsQCgaJpZM4WfoOh>
.
|
Thanks! So the next step would be just to release api-core and cloud-spanner, right? |
Yes, once we merge this. I'll try to do this tomorrow morning. :)
…On Mon, Sep 10, 2018 at 2:22 PM Weiran Fang ***@***.***> wrote:
No, releasetool will handle that.
Thanks! So the next step would be just to release api-core and
cloud-spanner, right?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#5904 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAPUc_X-hnE5HZjhjz8OXm_EB2UA7074ks5uZtgEgaJpZM4WfoOh>
.
|
We can't get tests passing for this PR until |
I think we should separate this into 2 pr, one for api core and another one for spanner. So we can release api core before spanner, correct? |
@WeiranFang This PR already touches |
I see, thanks for the clarification! |
#5904 made 'grpcio-gcp' an unconditional dependency.
#5904 made 'grpcio-gcp' an unconditional dependency.
Add grpcio-gcp as extra dependency in google-api-core
Add grpcio-gcp as hard dependency in google-cloud-spanner