Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

speech: add a sink to requestStream so events are not dropped #2461

Merged
merged 3 commits into from
Jul 17, 2017
Merged

speech: add a sink to requestStream so events are not dropped #2461

merged 3 commits into from
Jul 17, 2017

Conversation

stephenplusplus
Copy link
Contributor

@stephenplusplus stephenplusplus commented Jul 17, 2017 •
edited
Loading

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 17, 2017
@stephenplusplus stephenplusplus added the api: speech Issues related to the Speech-to-Text API. label Jul 17, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.89% when pulling f11ac40 on stephenplusplus:spp--speech-stream-fix into 6a6e761 on GoogleCloudPlatform:master.

stephenplusplus
stephenplusplus commented Jul 17, 2017
View reviewed changes
packages/speech/src/helpers.js
//
// This also means that the sending of the initial request (with the
// config) is delayed until we get the first burst of data.
recognizeStream.once('writing', () => {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.89% when pulling fe69bcc on stephenplusplus:spp--speech-stream-fix into 6a6e761 on GoogleCloudPlatform:master.

@stephenplusplus stephenplusplus merged commit eb34842 into googleapis:master Jul 17, 2017
@snyk-bot snyk-bot mentioned this pull request Mar 11, 2020
Open
sofisl pushed a commit that referenced this pull request Jan 24, 2023
@stephenplusplus
speech: add a sink to requestStream so events are not dropped (#2461)
6eec5d2 
* speech: add a sink to `requestStream` so events are not dropped
sofisl pushed a commit that referenced this pull request Jan 25, 2023
@stephenplusplus
speech: add a sink to requestStream so events are not dropped (#2461)
f86d288 
* speech: add a sink to `requestStream` so events are not dropped
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukesneeringer lukesneeringer lukesneeringer left review comments

Assignees
No one assigned
Labels
api: speech Issues related to the Speech-to-Text API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stephenplusplus @coveralls @lukesneeringer @googlebot